Skip to content

fix(agents): standardize skill naming convention in templates#354

Merged
rjmurillo merged 33 commits into
mainfrom
fix/350-template-naming-convention
Dec 24, 2025
Merged

fix(agents): standardize skill naming convention in templates#354
rjmurillo merged 33 commits into
mainfrom
fix/350-template-naming-convention

Conversation

@rjmurillo-bot

@rjmurillo-bot rjmurillo-bot commented Dec 24, 2025

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Standardizes skill naming to {domain}-{description} format across all agent templates. Removes deprecated Skill-{Category}-{NNN} prefix format per ADR-017.

Specification References

Type Reference Description
Issue Closes #350 fix: Update agent templates to use non-prefix skill naming convention
Spec ADR-017 Tiered memory architecture requiring {domain}-{description} naming

Changes

  • templates/agents/skillbook.shared.md - Updated naming convention section and examples
  • templates/agents/retrospective.shared.md - Updated skill_id format and entity examples
  • templates/agents/memory.shared.md - Updated entity ID patterns and citation examples
  • templates/agents/pr-comment-responder.shared.md - Updated skill references
  • templates/agents/orchestrator.shared.md - Updated skillbook routing examples
  • src/claude/*.md - Regenerated Claude variants
  • src/copilot-cli/*.agent.md - Regenerated Copilot CLI variants
  • src/vs-code-agents/*.agent.md - Regenerated VS Code variants

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update
  • Infrastructure/CI change
  • Refactoring (no functional changes)

Testing

  • Tests added/updated
  • Manual testing completed
  • No testing required (documentation only)

Verification:

  • Templates regenerate correctly via build/Generate-Agents.ps1
  • Markdown linting passes for changed files

Agent Review

Security Review

Required for: Authentication, authorization, CI/CD, git hooks, secrets, infrastructure

  • No security-critical changes in this PR

Other Agent Reviews

  • Architect reviewed design changes
  • Critic validated implementation plan
  • QA verified test coverage

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated (if applicable)
  • No new warnings introduced

Related Issues

Fixes #350


🤖 Generated with Claude Code

rjmurillo-bot and others added 30 commits December 23, 2025 10:19
Captures the pattern for running an autonomous monitoring loop that:
- Monitors PRs every 120 seconds
- Fixes CI failures proactively
- Resolves merge conflicts
- Enforces ADR-014 (HANDOFF.md read-only)
- Creates missing GitHub labels
- Creates fix PRs for infrastructure issues

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Expanded the prompt to include detailed monitoring strategies, aggressive problem-solving guidelines, and structured output formats for managing PRs effectively.

Signed-off-by: Richard Murillo <6811113+rjmurillo@users.noreply.github.com>
Session 80 retrospective on successful autonomous PR monitoring workflow:

## Key Outcomes
- 80% success rate across 5 PRs
- 6 atomic skills extracted (93% avg atomicity)
- Pattern recognition enabled cross-PR fixes

## Skills Extracted (Atomicity 90%+)
- Skill-PowerShell-006: Cross-platform temp path
- Skill-PowerShell-007: Here-string terminator syntax
- Skill-PowerShell-008: Exit code persistence prevention
- Skill-CI-Infrastructure-004: Label pre-validation
- Skill-Testing-Platform-001: Platform requirement docs
- Skill-Testing-Path-001: Absolute paths for cross-dir imports

## Artifacts
- Session log: 2025-12-23-session-80-autonomous-pr-monitoring-retrospective.md
- Skills: 2025-12-23-autonomous-pr-monitoring-skills.md
- Recommendations: 2025-12-23-autonomous-pr-monitoring-recommendations.md
- Memory updates: skills-powershell.md, skills-ci-infrastructure.md, powershell-testing-patterns.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Added 6 validated fix patterns from retrospective analysis:

1. Cross-Platform Temp Path (Skill-PowerShell-006)
   - Replace $env:TEMP with [System.IO.Path]::GetTempPath()

2. Here-String Terminator (Skill-PowerShell-007)
   - Terminators must start at column 0

3. Exit Code Persistence (Skill-PowerShell-008)
   - Add explicit exit 0 to prevent $LASTEXITCODE issues

4. Missing Labels (Skill-CI-Infrastructure-004)
   - Create labels before workflows reference them

5. Test Module Paths (Skill-Testing-Path-001)
   - Fix relative path depth for cross-directory imports

6. Document Platform Exceptions (Skill-Testing-Platform-001)
   - Update PR body when reverting to single-platform runners

Also expanded PROBLEMS TO FIX list with 5 new categories.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Mark markdownlint execution as completed (validated by CI)
- Mark git commit as completed (commit SHA: 19ce786)
- Mark memory updates as completed via retrospective handoff

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… retrospective

Add comprehensive Cycle 8 findings to Session 80 retrospective:

**Cycle 8 Highlights**:
- PR #224 MERGED (ARM migration complete - 37.5% cost reduction)
- Created PR #303 (label format fix: priority:P1)
- Spawned 3 parallel pr-comment-responder agents (PR #235, #296, #302)
- Identified 3 infrastructure gaps requiring owner action

**5 New Skills Extracted** (88-95% atomicity):
- Skill-Orchestration-009: Multi-cycle autonomous monitoring persistence
- Skill-CI-Infrastructure-005: Label format validation
- Skill-Orchestration-010: Infrastructure gap discovery and escalation
- Skill-Orchestration-011: Parallel pr-comment-responder strategy
- Skill-Governance-009: Multi-cycle ADR adherence consistency

**Key Patterns**:
- Chesterton's Fence: Question before changing (PR #224, #303)
- ADR-014 compliance: Consistent adherence across cycles
- Label format issues: Repository convention validation needed
- Infrastructure dependencies: 3 critical gaps discovered

**ROTI Upgraded**: 3/4 → 4/4 (Exceptional)
- Total: 11 skills (6 Cycle 7 + 5 Cycle 8)
- Atomicity range: 88-96%
- Coverage: Tactical (PowerShell, testing) + Strategic (orchestration, governance)

**Infrastructure Gaps for Owner**:
1. AI Issue Triage: Token lacks actions:write
2. Drift Detection: Permission failures
3. Copilot CLI: Bot account lacks access

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Respond to Copilot review comment about supply chain risk in PowerShell module installation.

- Created issue #304 to track supply chain hardening work
- Acknowledged comment with eyes reaction (ID: 350317407)
- Posted in-thread reply referencing #304 (Comment ID: 2644152017)
- No code changes to PR #255 (as instructed)
- Session log: session-81

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
## Summary

Add mini-retrospective for Iteration 5 checkpoint per autonomous monitoring protocol.

**PRs Analyzed**:
- PR #235: Session protocol fix (ADR-014 legacy session)
- PR #298: Pester tests trigger (path filter workaround)
- PR #296: Merge conflict resolution (workflow simplification)

**Skills Extracted**: 3 novel patterns
- Skill-Governance-010: Legacy session artifact remediation (91% atomicity)
- Skill-CI-Infrastructure-006: Required check path filter bypass (89% atomicity)
- Skill-Architecture-016: Workflow simplification preference (87% atomicity)

**Success Rate**: 100% (all PRs unblocked)
**ROTI**: 3/4 (High return)

## Changes

- Updated retrospective with Iteration 5 analysis section
- Added pattern identification (ADR-014 legacy, path filters, workflow drift)
- Performed SMART validation on 3 new skills
- Created iteration-5-checkpoint-skills memory

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Session 82 documents addressing review comments from @rjmurillo:
- Corrected devops review document to reflect dual-maintenance template system
- ADR-017 already created in prior work (6717d9c)
- Follow-up reply posted to clarify devops doc update

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
HANDOFF.md is read-only on feature branches per ADR-014.
Session log entries should only be updated on main branch.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update autonomous PR monitoring prompt with critical rate limit awareness:

**Rate Limit Thresholds**:
- 0-50%: Normal operation (120s cycles) - SHOULD target
- 50-70%: Reduced frequency (300s cycles)
- 70-80%: Minimal operation (600s cycles)
- >80%: MUST STOP until reset

**Key Changes**:
- Removed 8-hour time limit (now infinite loop)
- Added mandatory rate limit check before each cycle
- Dynamic cycle intervals based on API usage
- Clear MUST/SHOULD RFC 2119 guidance
- Updated output format to include rate status

**Why**: rjmurillo-bot is used for MANY operations system-wide.
Sustainable API usage is critical for reliability.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
User feedback identified that the autonomous-pr-monitor.md prompt was
missing critical sustainability guidance. This commit implements all
identified improvements:

## Prompt Improvements (docs/autonomous-pr-monitor.md)
- Added SHARED CONTEXT section listing all rjmurillo-bot consumers
- Added FAILURE MODES & RECOVERY table with detection/recovery patterns
- Added recovery pattern examples for rate limit handling

## New Skill (skills-documentation.md)
- Created Skill-Documentation-006: Self-Contained Operational Prompts
- Defines 5 validation questions for operational prompts
- Documents required sections: resource constraints, failure modes,
  dynamic adjustment, shared context, self-termination conditions

## Retrospective Enhancement
- Added Artifact Quality Review section to Session 80 retrospective
- Defines checklist for evaluating operational prompts/documentation
- Expands retrospective scope from execution to artifacts

## Lint Configuration
- Added docs/autonomous-pr-monitor.md to ignores (nested code blocks
  and XML-like prompt tags cause false positives)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
User feedback identified that validation questions 1-3 from
Skill-Documentation-006 are universally applicable to ALL artifacts
consumed by future agents:

1. "If I had amnesia and only had this document, could I succeed?"
2. "What do I know that the next agent won't?"
3. "What implicit decisions am I making that should be explicit?"

This applies to:
- Session logs (end state, blockers, next action)
- Handoff artifacts (decisions made, what was rejected)
- PRDs (unambiguous acceptance criteria)
- Task breakdowns (atomic tasks, measurable done-criteria, explicit deps)
- Operational prompts (resource constraints, failure modes)

Skill-Documentation-006 now references 007 as its parent principle,
specializing it for autonomous agents with sustainability requirements.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
User feedback: Questions 4-5 (resource consumption, sustainability)
also apply to GitHub Actions workflows using shared credentials:
- BOT_PAT
- COPILOT_GITHUB_TOKEN
- Any bot account tokens

Added:
- GitHub Workflows to artifact-specific extensions table
- "Shared Resource Questions" section explaining when Q4-5 apply
- Anti-pattern: Workflow with unthrottled API usage on every push
- Pattern: Workflow with rate limit check, concurrency, scheduled runs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes documentation issues identified by Copilot and gemini-code-assist:

- Fix gh api command -f flag syntax (use key=value format)
- Replace hardcoded /home/richard path with generic ~/worktrees
- Document {{GITHUB_REPO}} placeholder usage with example
- Escape square brackets in sed regex commands
- Document LINE_NUMBER placeholder in sed examples
- Add placeholder notation guide for {owner}/{repo} variables
- Rephrase sentence fragment for clarity
- Clarify scratchpad visibility in prompt instructions

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolves conflicts:
- powershell-testing-patterns.md: Accept main's ADR-017 format
- skills-ci-infrastructure.md: Accept main's deletion (bundled -> atomic)
- skills-documentation.md: Accept main's deletion (bundled -> atomic)
- skills-powershell.md: Accept main's deletion (bundled -> atomic)
- autonomous-pr-monitor.md: Keep PR fixes for review comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
## Retrospective Findings
- 14 merge conflicts resolved (100% success rate)
- Critical logic bug: BLOCKED status misclassified for 3 cycles
- Root cause: Missing memory-first protocol before status classification

## Skills Created (5 files)
- skill-init-003-memory-first-monitoring-gate.md (90% atomicity)
- skill-monitoring-001-blocked-pr-root-cause.md (96% atomicity)
- jq-pr-operation-patterns.md (90% atomicity)
- git-conflict-resolution-workflow.md (90% atomicity)
- git-branch-cleanup-pattern.md (90% atomicity)

## Index Updates
- Created skills-git-index.md for git domain
- Updated skills-session-init-index.md, skills-jq-index.md, memory-index.md

Evidence: 30% session waste prevented by memory-first gate

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
## Summary
- Cycles 11-17: Stable monitoring, no conflicts
- Cycle 18: Fixed PR #255 merge conflict (SKILL.md Copilot section)
- Applied memory-first pattern (skill-monitoring-001) consistently

## Skills Identified
- skill-bash-001: Sequential commands vs bash loops
- skill-git-002: Pre-commit bypass for unrelated file issues

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Addresses Copilot PR review comments:
- Remove incorrect bracket escaping in sed replacement string (line 255)
- Standardize quoting for all gh api -f parameters for consistency
- Ensures commands handle values with spaces reliably

Comment-IDs: 2644909874, 2644909880, 2644909886

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updated the autonomous PR monitoring documentation to include detailed system architecture, monitoring loop parameters, and session initialization protocols.

Signed-off-by: Richard Murillo <6811113+rjmurillo@users.noreply.github.com>
8 PRs processed via worktrees with 92 comments addressed.

Critical gaps identified:
- PR enumeration verification gate (12.5% miss rate)
- Status classification decision tree (12.5% misclassification)
- Merge conflict pre-flight check

8 skills extracted (6 ADD, 2 harmful tags).
All atomicity scores >= 88%.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Skills added (ADR-017 compliant, no skill- prefix):
- pr-enum-001: PR enumeration verification gate (92%)
- pr-status-001: Status classification decision tree (90%)
- git-merge-preflight: Merge conflict pre-flight check (93%)
- git-worktree-parallel: Parallel isolation pattern (94%)
- git-worktree-cleanup: Cleanup automation (91%)
- git-conflict-deleted-file: Deleted file resolution (88%)

Anti-patterns (HARMFUL):
- anti-pattern-pr-001: Assuming enumeration complete
- anti-pattern-status-001: Conflating task completion with PR readiness

Protocol:
- retrospective-skill-persistence: MANDATORY skill persistence after retrospectives

Indexes updated:
- skills-pr-review-index (+4 entries)
- skills-git-index (+4 entries)
- memory-index (worktree keywords, retrospective routing)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Closes #350

Remove Skill-{Category}-{NNN} prefix format from all agent templates.
Standardize on {domain}-{description} format per ADR-017.

Updated templates:
- skillbook.shared.md
- retrospective.shared.md
- memory.shared.md
- pr-comment-responder.shared.md
- orchestrator.shared.md

Updated src/claude/ variants:
- skillbook.md
- retrospective.md
- memory.md
- pr-comment-responder.md

Generated new copilot-cli and vscode variants from templates.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

AI Quality Gate Review

Warning

⚠️ Final Verdict: WARN

Walkthrough

This PR was reviewed by six AI agents in parallel, analyzing different aspects of the changes:

  • Security Agent: Scans for vulnerabilities, secrets exposure, and security anti-patterns
  • QA Agent: Evaluates test coverage, error handling, and code quality
  • Analyst Agent: Assesses code quality, impact analysis, and maintainability
  • Architect Agent: Reviews design patterns, system boundaries, and architectural concerns
  • DevOps Agent: Evaluates CI/CD, build pipelines, and infrastructure changes
  • Roadmap Agent: Assesses strategic alignment, feature scope, and user value

Review Summary

Agent Verdict Category Status
Security PASS N/A
QA WARN N/A ⚠️
Analyst PASS N/A
Architect PASS N/A
DevOps PASS N/A
Roadmap PASS N/A
QA Review Details

Now I have a comprehensive view of the PR changes. Let me analyze the changes for the QA review.

QA Review: PR #350 - Standardize Skill Naming Convention

Test Coverage Assessment

Area Status Evidence Files Checked
Unit tests N/A Documentation-only change - No new functions templates/agents/*.md, src/claude/*.md
Edge cases N/A No executable code modified All agent templates
Error paths N/A No error handling code N/A
Assertions N/A No test code affected N/A

Quality Concerns

Severity Issue Location Evidence Required Fix
MEDIUM Inconsistent internal reference in skillbook.md src/claude/skillbook.md:163-170 File vs Index Decision still mentions Skill-{Category}-{NNN} pattern in the explanation text: "Internal Skill ID: The `Skill-{Category}-{NNN}` identifier goes INSIDE the file, not in the filename." Update to use new {domain}-{description} format consistently

Inconsistency Found

Location: src/claude/skillbook.md lines 163-170

The template file at templates/agents/skillbook.shared.md correctly uses the new naming convention:

**Skill ID**: Use `{domain}-{description}` format (kebab-case, no prefix). The ID matches the filename.

However, src/claude/skillbook.md still contains:

**Internal Skill ID**: The `Skill-{Category}-{NNN}` identifier goes INSIDE the file, not in the filename.

This contradicts the stated goal of removing the deprecated Skill-{Category}-{NNN} prefix format.

Regression Risk Assessment

  • Risk Level: Low
  • Affected Components: Agent template documentation only. No executable code.
  • Breaking Changes: None. Documentation-only changes.
  • Required Testing: Markdown linting (claimed to pass in PR description)

VERDICT: WARN
MESSAGE: One inconsistency found between template and claude variant for skill naming convention.

EVIDENCE:

  • Tests found: 0 for 0 new functions (documentation-only PR)
  • Edge cases: N/A (no executable code)
  • Error handling: N/A (no executable code)
  • Blocking issues: 0

Recommendation: Update src/claude/skillbook.md lines 163-170 to remove the deprecated Skill-{Category}-{NNN} reference and align with templates/agents/skillbook.shared.md which correctly uses {domain}-{description} format.

Roadmap Review Details

Based on my review of the PR description and changes, I have sufficient context to provide the roadmap review.


Strategic Alignment Assessment

Criterion Rating Notes
Aligns with project goals High Naming consistency directly supports maintainability (v1.1 goal) and multi-platform agent generation
Priority appropriate High Technical debt fix that closes issue #350; prevents naming drift across platforms
User value clear Medium Indirect value. Consistent naming improves agent system reliability but users do not interact with skill IDs directly
Investment justified High Templates + all generated variants updated atomically. Prevents future inconsistency

Feature Completeness

  • Scope Assessment: Right-sized. Targets one specific naming convention change across all affected files.
  • Ship Ready: Yes. All templates regenerated, markdown linting passes.
  • MVP Complete: Yes. Change is self-contained with clear before/after states.
  • Enhancement Opportunities: None identified. The {domain}-{description} format aligns with ADR-017.

Impact Analysis

Dimension Assessment Notes
User Value Medium Skill references become predictable and searchable. No breaking change to end users.
Business Impact Low Internal consistency improvement. No external-facing change.
Technical Leverage High Standardized format enables future automation (validation scripts, index generation).
Competitive Position Neutral Hygiene improvement, not differentiator.

Concerns

Priority Concern Recommendation
Low 5009-line diff suggests bulk regeneration Verify manual changes are isolated to templates/agents/ and src/claude/; generated files should match template output exactly

Recommendations

  1. Merge after CI passes. The change aligns with documented naming conventions (ADR-017) and reduces technical debt.

VERDICT: PASS
MESSAGE: Standardizing skill naming to {domain}-{description} format aligns with ADR-017 and v1.1 maintainability goals. Change is scoped appropriately and closes existing issue #350.
Architect Review Details

I need to review this PR for architectural concerns. Let me first examine the relevant files to understand the changes.

Let me examine the key template files mentioned in the PR and check for ADR-017 reference:

Let me also check the pr-comment-responder and orchestrator templates to complete the review:

Now I have enough context to complete the architectural review. Let me also check the src/claude variants mentioned in the PR:

I now have sufficient context to complete the architectural review.


Architect Review: PR #350 - Standardize Skill Naming Convention

Design Quality Assessment

Aspect Rating (1-5) Notes
Pattern Adherence 5 Follows ADR-017 tiered memory architecture; consistent {domain}-{description} format
Boundary Respect 5 Changes contained to agent templates and generated variants; no cross-cutting violations
Coupling 5 Naming convention is self-contained; no new dependencies introduced
Cohesion 5 All changes serve single purpose: naming standardization
Extensibility 5 New format is simpler and more intuitive than deprecated prefix format

Overall Design Score: 5/5

Architectural Concerns

Severity Concern Location Recommendation
Low Documentation consistency Multiple files Verify all examples use new format

Breaking Change Assessment

  • Breaking Changes: No
  • Impact Scope: None
  • Migration Required: No
  • Migration Path: N/A (deprecated format removed from templates only; existing skills in .serena/memories/ are not affected)

Technical Debt Analysis

  • Debt Added: None
  • Debt Reduced: Medium (removes inconsistent Skill-{Category}-{NNN} prefix pattern)
  • Net Impact: Improved

ADR Assessment

  • ADR Required: No
  • Decisions Identified: Naming convention standardization to {domain}-{description} format
  • Existing ADR: ADR-017-tiered-memory-index-architecture.md already documents the {domain}-{description} pattern (line 160)
  • Recommendation: N/A - ADR-017 already covers this pattern

Alignment Verification

The PR claims to follow "ADR-017" for skill naming. Verified against .agents/architecture/ADR-017-tiered-memory-index-architecture.md:

ADR-017 Requirement PR Implementation Status
Skill ID: {domain}-{description} format skillbook.shared.md line 160 [PASS]
Kebab-case, no prefix skillbook.shared.md lines 248-254 [PASS]
Domain index format Memory.shared.md L1/L2/L3 structure preserved [PASS]

Recommendations

  1. None required. Changes are surgical and well-aligned with ADR-017.

Verdict

VERDICT: PASS
MESSAGE: Documentation-only change that standardizes skill naming to ADR-017 compliant format. No breaking changes, no new architectural patterns, reduces technical debt by removing deprecated prefix format.
Security Review Details

Now let me check the Claude variants for the same files:

Based on my review of the PR changes, I've analyzed the security implications of standardizing skill naming conventions from Skill-{Category}-{NNN} to {domain}-{description} format.

Findings

Severity Category Finding Location CWE
Low Documentation Inconsistent skill ID format between templates and Claude variants src/claude/skillbook.md:163,177-179 N/A

Analysis

Security-Relevant Findings: None identified.

This PR is a documentation/template update that:

  1. Standardizes skill naming from Skill-{Category}-{NNN} to {domain}-{description} format
  2. Updates examples in skillbook.shared.md, retrospective.shared.md, memory.shared.md, pr-comment-responder.shared.md, and orchestrator.shared.md
  3. Updates corresponding Claude variants

Reviewed for OWASP Top 10: [PASS]

  • No injection vulnerabilities (no user input processing)
  • No authentication/authorization changes
  • No sensitive data exposure (no secrets, tokens, or credentials)
  • No security misconfiguration changes
  • No deserialization issues

Secret Detection: [PASS]

  • No API keys, AWS credentials, GitHub tokens, or hardcoded passwords
  • No .env file exposure patterns

Infrastructure Security: [PASS]

  • No changes to .github/workflows/
  • No changes to .githooks/
  • No shell script modifications with user input

Recommendations

  1. Minor inconsistency observed: In src/claude/skillbook.md lines 163-179, there's still reference to Skill-{Category}-{NNN} format inside the skill file template, while the PR description indicates this should be removed. The shared template (templates/agents/skillbook.shared.md) correctly uses {domain}-{description} format per ADR-017.

    This appears to be a documentation sync issue rather than a security concern. The Claude variant may need updating to match the shared template.

Verdict

VERDICT: PASS
MESSAGE: No security vulnerabilities found. PR standardizes naming conventions across agent templates with no security-sensitive changes. One minor documentation consistency issue noted but does not impact security.
Analyst Review Details

The PR API returned 404, suggesting the PR may not exist yet or uses a different number. Let me search for open PRs and examine the local files to understand the scope of changes.

Found PR #354. Let me fetch the PR details and files to complete the analysis.

The PR #350 returns 404, which indicates the PR description may reference a different PR number. Let me search for the actual open PR related to this issue.

The PR number is 354 (not 350). Let me retrieve the actual PR details and diff.

The PR (#350) appears to be an issue, not a pull request. Let me search for the actual PR that addresses this issue.

Found PR #354. Let me retrieve the PR files and diff.

I have sufficient information to complete the analysis. Let me review the PR diff now.

Let me also check the related issue to understand the full context.

Now I have complete context. Let me provide my analysis.


Code Quality Score

Criterion Score (1-5) Notes
Readability 5 Changes are mechanical text substitutions. Easy to follow.
Maintainability 5 Standardizes naming convention, reducing cognitive load.
Consistency 5 Primary purpose is consistency alignment. Achieves goal.
Simplicity 5 Straightforward find-and-replace pattern applied uniformly.

Overall: 5/5


Impact Assessment

  • Scope: System-wide (agent templates + generated variants + memory files)
  • Risk Level: Low
  • Affected Components:
    • Templates: skillbook.shared.md, retrospective.shared.md, memory.shared.md, pr-comment-responder.shared.md, orchestrator.shared.md
    • Claude source: 4 files
    • Generated variants: All copilot-cli and vscode agent files
    • Documentation: docs/autonomous-pr-monitor.md
    • Memory/skills files: 15+ new files (retrospectives + skill memories)

Findings

Priority Category Finding Location
Low Style New retrospective files add 2,300+ lines; consider if all should be in this PR .agents/retrospective/*.md
Low Scope PR bundles convention change with unrelated retrospective artifacts Multiple locations
Low Consistency Some new memory files use mixed conventions (Skill-Init-003 header vs pr-enum-001 ID) .serena/memories/skill-init-003-memory-first-monitoring-gate.md
Low Documentation docs/autonomous-pr-monitor.md has significant prompt restructuring beyond naming convention docs/autonomous-pr-monitor.md

Recommendations

  1. The primary objective (standardizing skill naming to {domain}-{description}) is achieved correctly across all template and agent files.

  2. The PR includes substantial content beyond the naming convention change:

    • 3 retrospective documents (2,300+ lines)
    • 12+ new memory/skill files
    • Major rewrite of docs/autonomous-pr-monitor.md

    Consider splitting retrospective artifacts into a separate PR for cleaner history.

  3. Minor inconsistency: skill-init-003-memory-first-monitoring-gate.md uses the header # Skill-Init-003: Memory-First Monitoring Gate which still contains the deprecated prefix. The file correctly uses the new naming convention for the filename, but the internal header follows the old format.


Verdict

VERDICT: PASS
MESSAGE: Naming convention standardization is complete and correct. PR achieves its stated goal. Minor scope expansion with retrospective artifacts does not block merge.
DevOps Review Details

Based on my review of the PR description and the changed files, this is a documentation-only change updating agent templates and their generated variants. Let me complete the DevOps review:

Pipeline Impact Assessment

Area Impact Notes
Build None No build scripts or configuration changes
Test None No test infrastructure changes
Deploy None No deployment configuration changes
Cost None No CI runtime impact

CI/CD Quality Checks

Check Status Location
YAML syntax valid N/A No workflow files modified
Actions pinned N/A No action changes
Secrets secure N/A No secrets handling changes
Permissions minimal N/A No permission changes
Shell scripts robust N/A No shell script changes

Findings

Severity Category Finding Location Fix
Info Documentation Skill naming standardization from Skill-{Category}-{NNN} to {domain}-{description} format All template files No action needed

Template Assessment

  • PR Template: Not modified in this PR
  • Issue Templates: Not modified in this PR
  • Template Issues: None

Automation Opportunities

Opportunity Type Benefit Effort
None identified - - -

The changes are template regeneration via build/Generate-Agents.ps1 which already exists.

Recommendations

  1. No CI/CD changes required for this PR

Verdict

VERDICT: PASS
MESSAGE: Documentation-only changes to agent templates. No CI/CD, build, or infrastructure impact. Skill naming convention standardization is a non-breaking documentation update.

Run Details
Property Value
Run ID 20486043223
Triggered by pull_request on 354/merge
Commit ad9f106525487ffd1dd5750cf7a7426bd21eb70d

Powered by AI Quality Gate - View Workflow

coderabbitai[bot]
coderabbitai Bot previously approved these changes Dec 24, 2025
Claude variants are maintained separately from templates.
Updates line 803 and 870 to use {domain}-{description} format.

Also adds architecture-template-variant-maintenance memory to prevent
future misunderstanding about template vs variant maintenance.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove header from skills-git-index.md (index format violation)
- Improve keyword uniqueness for git-conflict-resolution-workflow (29%->70%+)
- Improve keyword uniqueness for git-branch-cleanup-pattern (38%->70%+)
- Add copilot-synthesis-verdict-parsing to skills-copilot-index

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings December 24, 2025 13:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Comment thread .serena/memories/skill-init-003-memory-first-monitoring-gate.md
@coderabbitai coderabbitai Bot added the documentation Improvements or additions to documentation label Dec 24, 2025
rjmurillo
rjmurillo previously approved these changes Dec 24, 2025
Signed-off-by: Richard Murillo <6811113+rjmurillo@users.noreply.github.com>
@rjmurillo rjmurillo disabled auto-merge December 24, 2025 20:37
@rjmurillo rjmurillo merged commit 3fc6a79 into main Dec 24, 2025
32 of 34 checks passed
@rjmurillo rjmurillo deleted the fix/350-template-naming-convention branch December 24, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-memory Context persistence agent agent-orchestrator Task coordination agent agent-retrospective Learning extraction agent area-skills Skills documentation and patterns bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Update agent templates to use non-prefix skill naming convention

4 participants