Skip to content

feat: gigacode#92

Merged
NathanFlurry merged 1 commit intomainfrom
02-05-feat_gigacode
Feb 6, 2026
Merged

feat: gigacode#92
NathanFlurry merged 1 commit intomainfrom
02-05-feat_gigacode

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@railway-app railway-app bot temporarily deployed to sandbox-agent / sandbox-agent-pr-92 February 6, 2026 06:30 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 6, 2026

🚅 Deployed to the sandbox-agent-pr-92 environment in sandbox-agent

Service Status Web Updated (UTC)
website ✅ Success (View Logs) Web Feb 6, 2026 at 10:55 am

Copy link
Member Author

NathanFlurry commented Feb 6, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 6, 2026

Code Review

Found 3 issues that need to be addressed:

1. Missing newline in format string (cli.rs:579)

File: server/packages/sandbox-agent/src/cli.rs
Line: 579

The format string is missing a newline between "powered by:" and "- OpenCode". This produces malformed output where the colon runs directly into the bullet dash instead of starting the bullet list on a new line.

Reference:

let name = if cli.gigacode { "GigaCode" } else { "OpenCode command" };
write_stderr_line(&format!("EXPERIMENTAL: Please report bugs to:\n- GitHub: https://github.com/rivet-dev/sandbox-agent/issues\n- Discord: https://rivet.dev/discord\n\n{name} is powered by:- OpenCode (TUI): https://opencode.ai/\n- Sandbox Agent SDK (multi-agent compatibility): https://sandboxagent.dev/\n\n"))?;


2. Missing Windows crate feature (Cargo.toml:45)

File: server/packages/sandbox-agent/Cargo.toml
Line: 45

The daemon.rs file uses windows::Win32::System::Threading APIs (OpenProcess, GetExitCodeProcess, PROCESS_QUERY_LIMITED_INFORMATION), but the windows crate dependency does not include the Win32_System_Threading feature. Without this feature, the code will fail to compile on Windows targets.

The features array should include "Win32_System_Threading".

Reference:

[target.'cfg(windows)'.dependencies]
windows = { version = "0.52", features = ["Win32_Foundation", "Win32_Security", "Win32_Storage_FileSystem", "Win32_System_Console"] }


3. Linux install script does not handle ARM64 architecture (gigacode-install.sh:35)

File: scripts/release/static/gigacode-install.sh
Line: 35

The Linux branch unconditionally uses the x86_64 binary without checking the architecture. On ARM64/aarch64 Linux systems, this will download the x86_64 binary which will not execute.

The macOS branch correctly handles this by checking ARCH for both x86_64 and arm64. The Linux branch should do the same.

Reference:

elif [ "$(printf '%s' "$UNAME" | cut -c 1-5)" = "Linux" ]; then
echo
echo "> Detected Linux ($(getconf LONG_BIT) bit)"
FILE_NAME="gigacode-x86_64-unknown-linux-musl"
else


Copy link
Member Author

NathanFlurry commented Feb 6, 2026

Merge activity

  • Feb 6, 10:49 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 10:51 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.
  • Feb 6, 10:55 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 10:55 AM UTC: @NathanFlurry merged this pull request with Graphite.

@NathanFlurry NathanFlurry changed the base branch from feat-add-anycode-daemonized-opencode-cli-and-docs to graphite-base/92 February 6, 2026 10:49
@NathanFlurry NathanFlurry changed the base branch from graphite-base/92 to main February 6, 2026 10:49
@railway-app railway-app bot temporarily deployed to sandbox-agent / sandbox-agent-pr-92 February 6, 2026 10:55 Destroyed
@NathanFlurry NathanFlurry mentioned this pull request Feb 6, 2026
@NathanFlurry NathanFlurry merged commit a023934 into main Feb 6, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant