Conversation
|
🚅 Deployed to the sandbox-agent-pr-92 environment in sandbox-agent
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewFound 3 issues that need to be addressed: 1. Missing newline in format string (cli.rs:579)File: server/packages/sandbox-agent/src/cli.rs The format string is missing a newline between "powered by:" and "- OpenCode". This produces malformed output where the colon runs directly into the bullet dash instead of starting the bullet list on a new line. Reference: sandbox-agent/server/packages/sandbox-agent/src/cli.rs Lines 578 to 580 in 9235d88 2. Missing Windows crate feature (Cargo.toml:45)File: server/packages/sandbox-agent/Cargo.toml The daemon.rs file uses windows::Win32::System::Threading APIs (OpenProcess, GetExitCodeProcess, PROCESS_QUERY_LIMITED_INFORMATION), but the windows crate dependency does not include the Win32_System_Threading feature. Without this feature, the code will fail to compile on Windows targets. The features array should include "Win32_System_Threading". Reference: sandbox-agent/server/packages/sandbox-agent/Cargo.toml Lines 44 to 46 in 9235d88 3. Linux install script does not handle ARM64 architecture (gigacode-install.sh:35)File: scripts/release/static/gigacode-install.sh The Linux branch unconditionally uses the x86_64 binary without checking the architecture. On ARM64/aarch64 Linux systems, this will download the x86_64 binary which will not execute. The macOS branch correctly handles this by checking ARCH for both x86_64 and arm64. The Linux branch should do the same. Reference: sandbox-agent/scripts/release/static/gigacode-install.sh Lines 31 to 36 in 9235d88 |
Merge activity
|
9235d88 to
8663f50
Compare

No description provided.