fix: credential detection and provider auth status#120
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
|
🚅 Deployed to the sandbox-agent-pr-120 environment in sandbox-agent
|
1c372bc to
53ec13f
Compare
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
53ec13f to
50bb7c3
Compare
This was referenced Feb 7, 2026
50bb7c3 to
bc7010d
Compare
Merge activity
|
## Summary Fix credential detection bugs and add credential availability status to the API. Consolidate Claude fallback models and add `sonnet` alias. Builds on #109 (OAuth token support). Related issues: - Fixes #117 (Claude, Codex not showing up in gigacode) - Related to #113 (Default agent should be Claude Code) ## Changes ### Credential detection fixes - **`agent-credentials/src/lib.rs`**: Fix `?` operator bug in `extract_claude_credentials` - now continues to next config path if one is missing instead of returning early ### API credential status - **`sandbox-agent/src/router.rs`**: Add `credentialsAvailable` field to `AgentInfo` struct - **`/v1/agents`** endpoint now reports whether each agent has valid credentials ### OpenCode provider improvements - **`sandbox-agent/src/opencode_compat.rs`**: Build `connected` array based on actual credential availability, not just model presence - Check provider-specific credentials for OpenCode groups (e.g., `opencode:anthropic` only connected if Anthropic creds available) - Add logging when credential extraction fails in model cache building ### Fallback model consolidation - Renamed `claude_oauth_fallback_models()` → `claude_fallback_models()` (used for all fallback cases, not just OAuth) - Added `sonnet` to fallback models (confirmed working via headless CLI test) - Added `codex_fallback_models()` for Codex when credentials missing - Added comment explaining aliases work for both API and OAuth users ### Documentation - **`docs/credentials.mdx`**: New reference doc covering credential sources, extraction behavior, and error handling - Documents that extraction failures are silent (not errors) - Documents that agents spawn without credential pre-validation ### Inspector UI - **`AgentsTab.tsx`**: Added credential status pill showing "Authenticated" or "No Credentials" ## Error Handling Philosophy - **Extraction failures are silent**: Missing/malformed config files don't error, just continue to next source - **Agents spawn without credential validation**: No pre-flight auth check; agent's native error surfaces if credentials are missing - **Fallback models for UI**: When credentials missing, show alias-based models so users can still configure sessions ## Validation - Tested Claude Code model aliases via headless CLI: - `claude --model default --print "say hi"` ✓ - `claude --model sonnet --print "say hi"` ✓ - `claude --model haiku --print "say hi"` ✓ - Build passes - TypeScript types regenerated with `credentialsAvailable` field
bc7010d to
c54f83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix credential detection bugs and add credential availability status to the API. Consolidate Claude fallback models and add
sonnetalias.Builds on #109 (OAuth token support).
Related issues:
Changes
Credential detection fixes
agent-credentials/src/lib.rs: Fix?operator bug inextract_claude_credentials- now continues to next config path if one is missing instead of returning earlyAPI credential status
sandbox-agent/src/router.rs: AddcredentialsAvailablefield toAgentInfostruct/v1/agentsendpoint now reports whether each agent has valid credentialsOpenCode provider improvements
sandbox-agent/src/opencode_compat.rs: Buildconnectedarray based on actual credential availability, not just model presenceopencode:anthropiconly connected if Anthropic creds available)Fallback model consolidation
claude_oauth_fallback_models()→claude_fallback_models()(used for all fallback cases, not just OAuth)sonnetto fallback models (confirmed working via headless CLI test)codex_fallback_models()for Codex when credentials missingDocumentation
docs/credentials.mdx: New reference doc covering credential sources, extraction behavior, and error handlingInspector UI
AgentsTab.tsx: Added credential status pill showing "Authenticated" or "No Credentials"Error Handling Philosophy
Validation
claude --model default --print "say hi"✓claude --model sonnet --print "say hi"✓claude --model haiku --print "say hi"✓credentialsAvailablefield