Env to hide job args on list view by default, overridable in UI #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
approved these changes
May 12, 2025
cmd/riverui/main.go
Outdated
| corsOrigins = strings.Split(os.Getenv("CORS_ORIGINS"), ",") | ||
| databaseURL = os.Getenv("DATABASE_URL") | ||
| devMode = envBooleanTrue(os.Getenv("DEV")) | ||
| jobListHideArgsByDefault = envBooleanTrue(os.Getenv("JOB_LIST_HIDE_ARGS_BY_DEFAULT")) |
Collaborator
There was a problem hiding this comment.
Should we prefix this with RIVER?
Contributor
Author
There was a problem hiding this comment.
yeah good call, changed that!
bgentry
added a commit
that referenced
this pull request
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature request came from a customer whose job args are encoded protobufs, which makes them long and ugly to look at in the UI. The request was to provide a way to hide them in the list view, which I made possible via
RIVER_JOB_LIST_HIDE_ARGS_BY_DEFAULT.I also used this as an excuse to build out a settings screen in the UI to allow it to be overridden by the user. The preference is kept in local storage and can be cleared out to revert to the default. The setting UI isn't anything special but should be fine for now.