chore: task local context for debugging#3969
Merged
Merged
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Contributor
There was a problem hiding this comment.
license-eye has totally checked 939 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 937 | 1 | 1 | 0 |
Click to see the invalid file list
- src/common/src/util/debug_context.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #3969 +/- ##
==========================================
- Coverage 73.88% 73.87% -0.01%
==========================================
Files 825 826 +1
Lines 116782 116827 +45
==========================================
+ Hits 86286 86308 +22
- Misses 30496 30519 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
skyzh
approved these changes
Jul 18, 2022
skyzh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. How to extract the context out of the task local variable?
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…wave into bz/debug-context
Contributor
Author
Like this. with_debug_context(|d| {
println!("{:?}", d);
assert!(d.as_stream_executor().is_some())
}); |
3 tasks
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
* chore: task local context for debugging Signed-off-by: Bugen Zhao <i@bugenzhao.com> * refine Signed-off-by: Bugen Zhao <i@bugenzhao.com> * Update src/common/src/util/debug_context.rs Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add context for batch executor creation Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. We previously used this for debugging #2580. Check the test below for usages.
https://github.com/singularity-data/risingwave/blob/e937aa66b405ad262b3849369af96ec24c2d1ae5/src/common/src/util/debug_context.rs#L42-L56
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)