Skip to content

DB-2993: export used direct memory#15

Merged
stef1927 merged 3 commits intoriptano:dse-netty-4.1.25.Finalfrom
stef1927:dse-netty-4.1.25.Final
Mar 12, 2019
Merged

DB-2993: export used direct memory#15
stef1927 merged 3 commits intoriptano:dse-netty-4.1.25.Finalfrom
stef1927:dse-netty-4.1.25.Final

Conversation

@stef1927
Copy link
Copy Markdown

@stef1927 stef1927 commented Mar 6, 2019

Identical to #14, no conflicts

@stef1927 stef1927 merged commit 6123a0a into riptano:dse-netty-4.1.25.Final Mar 12, 2019
emerkle826 pushed a commit that referenced this pull request Sep 3, 2025
netty#15220)

…217)

Motivation:
Right now the default compression level inside the used Deflater is
defined as "-1", which according to zlib manual also defaults to "6"
which is used inside netty as the default. That said, we should also
allow to provide Deflater.DEFAULT_COMPRESSION (-1) as an argument.

Modifications:
The range check has been modified to allow for -1 and it now uses the
constants instead of magic numbers. Small regression test added which
just makes sure that no exception is thrown when provided.

Result:
Fixes netty#15212

Co-authored-by: Michael Nitschinger <mnitschinger@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant