Skip to content

APP-119 feat: comparison in canvas charts #8290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djbarnwal merged 15 commits into from
Dec 16, 2025
Merged

APP-119 feat: comparison in canvas charts #8290

djbarnwal merged 15 commits into from
Dec 16, 2025

Conversation

@djbarnwal
Copy link
Member

@djbarnwal djbarnwal commented Nov 8, 2025 •
edited
Loading

When comparison time range is enabled add comparison to -

  • Line chart
  • Stacked bar chart
  • Grouped bar chart
  • Stacked normalized bar chart
  • Multi measure charts (all above types)

https://linear.app/rilldata/issue/APP-119/time-comparisons-on-canvas-charts

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@djbarnwal djbarnwal marked this pull request as ready for review November 24, 2025 00:42
@djbarnwal djbarnwal changed the title feat: comparison in bar charts feat: comparison in canvas charts Nov 24, 2025
@djbarnwal djbarnwal requested a review from ericokuma November 24, 2025 19:00
@ericokuma Linear
Copy link
Contributor

ericokuma commented Nov 25, 2025

So it looks like comparison only works for all chart types except donus, funnel, heatmap, and combo chart?

Also noticed that local time range comparison is only available on KPI grids, Tables, Leaderboards, but not charts?

@djbarnwal
Copy link
Member Author

djbarnwal commented Nov 25, 2025 •
edited
Loading

So it looks like comparison only works for all chart types except donut, funnel, heatmap, and combo chart?

Yes, not all chart types have a standard complimentary comparison version. If needed, we can think about comparison would look like for these charts and implement it as a follow up.

Also noticed that local time range comparison is only available on KPI grids, Tables, Leaderboards, but not charts?

Good catch, added it for chart types that support comparison.

@ericokuma Linear
Copy link
Contributor

ericokuma commented Nov 26, 2025

LGTM!

@ericokuma ericokuma changed the title feat: comparison in canvas charts APP-119 feat: comparison in canvas charts Dec 1, 2025
@ericokuma ericokuma requested a review from ericpgreen2 December 1, 2025 18:29
@ericpgreen2 ericpgreen2 removed their request for review December 4, 2025 03:01
@ericokuma
Copy link
Contributor

ericokuma commented Dec 8, 2025

@briangregoryholmes, when you get a chance, can you do a code review here? Thanks in advance!

@djbarnwal djbarnwal merged commit 9cfe283 into main Dec 16, 2025
10 checks passed
@djbarnwal djbarnwal deleted the feat/bar-chart-comparison branch December 16, 2025 20:19
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
@djbarnwal @k-anshul
APP-119 feat: comparison in canvas charts (#8290)
22177da 
* init bar comparisons

* formatting

* comparison without color dimension

* add comparison lines to line chart

* add comparison for stacked normalized charts

* add field details, remove __time hardcoding

* init comparison for multi measures

* Use const variables for field names

* Update var name

* Allow local comparison filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briangregoryholmes briangregoryholmes briangregoryholmes approved these changes

@ericokuma ericokuma ericokuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djbarnwal @ericokuma @briangregoryholmes