Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates Ridgepole’s diff generation to use the udiff gem instead of diffy, aligning the runtime dependency and the internal diff rendering implementation.
Changes:
- Replace the
diffyruntime dependency withudiff (>= 0.2.0). - Update Ridgepole’s require list to load
udiff. - Switch
diff_inspectto build diffs viaUdiff::Diff.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ridgepole.gemspec |
Swaps runtime dependency from diffy to udiff to support the new diff engine. |
lib/ridgepole.rb |
Updates the top-level require to load udiff. |
lib/ridgepole/diff.rb |
Migrates diff_inspect implementation to use Udiff::Diff. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@winebarrel I've opened a new pull request, #658, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: winebarrel <117768+winebarrel@users.noreply.github.com> Agent-Logs-Url: https://github.com/ridgepole/ridgepole/sessions/e1e3e11b-83d4-4edd-969f-3ff37e27b298
Rename `diffy` variable to `diff` in `diff_inspect`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 22 22
Lines 1478 1478
=======================================
Hits 1435 1435
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request updates Ridgepole to use the
udiffgem instead ofdiffyfor generating diffs. The main changes involve swapping out the diffing library in both the codebase and the gemspec, ensuring compatibility and updating dependencies accordingly.Dependency update:
diffygem with theudiffgem (version >= 0.2.0) in theridgepole.gemspecfile, removing the old dependency and adding the new one.Code changes for diffing:
lib/ridgepole.rb) to requireudiffinstead ofdiffy.diff_inspectmethod inlib/ridgepole/diff.rbto useUdiff::Difffor generating diffs, removing the explicit unified diff option sinceudiffhandles this internally.cf. https://github.com/winebarrel/udiff