Skip to content

Rename diffy variable to diff in diff_inspect#658

Merged
winebarrel merged 2 commits intouse-udifffrom
copilot/sub-pr-657
Mar 22, 2026
Merged

Rename diffy variable to diff in diff_inspect#658
winebarrel merged 2 commits intouse-udifffrom
copilot/sub-pr-657

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 22, 2026

The local variable diffy in diff_inspect was a leftover name from the diffy gem. After switching to Udiff::Diff, the name is misleading.

  • lib/ridgepole/diff.rb: Renamed diffydiff in diff_inspect

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] [WIP] Address feedback on 'Use udiff' PR Rename diffy variable to diff in diff_inspect Mar 22, 2026
Copilot AI requested a review from winebarrel March 22, 2026 01:49
@winebarrel winebarrel marked this pull request as ready for review March 22, 2026 01:49
@winebarrel winebarrel merged commit 107b342 into use-udiff Mar 22, 2026
234 of 235 checks passed
@winebarrel winebarrel deleted the copilot/sub-pr-657 branch March 22, 2026 02:12
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (692af2d) to head (0f54ded).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           use-udiff     #658   +/-   ##
==========================================
  Coverage      97.09%   97.09%           
==========================================
  Files             22       22           
  Lines           1478     1478           
==========================================
  Hits            1435     1435           
  Misses            43       43           
Flag Coverage Δ
2.7 96.54% <100.00%> (ø)
3.0 96.54% <100.00%> (ø)
3.1 96.61% <100.00%> (ø)
3.2 96.68% <100.00%> (ø)
3.3 97.01% <100.00%> (ø)
3.4 97.02% <100.00%> (ø)
4.0 97.02% <100.00%> (ø)
MYSQL57 89.17% <100.00%> (ø)
MYSQL80 91.61% <100.00%> (ø)
POSTGRESQL 81.58% <100.00%> (ø)
TRILOGY 89.03% <100.00%> (ø)
activerecord_6.1.gemfile 91.80% <100.00%> (ø)
activerecord_7.0.gemfile 91.80% <100.00%> (ø)
activerecord_7.1.gemfile 96.41% <100.00%> (ø)
activerecord_7.2.gemfile 96.41% <100.00%> (ø)
activerecord_8.0.gemfile 96.41% <100.00%> (ø)
activerecord_8.1.gemfile 96.48% <100.00%> (ø)
activerecord_8.2.gemfile 96.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants