A raw descriptor creation interface for the unvault#17
Merged
darosior merged 2 commits intorevault:masterfrom Oct 2, 2020
Merged
A raw descriptor creation interface for the unvault#17darosior merged 2 commits intorevault:masterfrom
darosior merged 2 commits intorevault:masterfrom
Conversation
Member
|
Ack 5feaa58 |
5feaa58 to
4ce85f3
Compare
Member
Author
|
Rebased after #10 rebase. |
edouardparis
previously requested changes
Sep 28, 2020
Member
edouardparis
left a comment
There was a problem hiding this comment.
small error s/bitcoinconsensus/bitcoin::consensus
clippy found it
Member
Author
|
Thanks! |
Member
Author
|
Actually it's that i (apparently) did not move it as part of the test mod. |
462df78 to
0b3ac78
Compare
Member
Author
|
Ok I actually fucked up #16's rebase (and merged it 😭), should be fixed now. |
c5a8c16 to
544a49b
Compare
Member
Author
|
Rebased after #10 rebase. |
This: - Moves bitcoinconsensus to a dev-only dep for the moment - Makes use of secp256k1's rand module - Makes use of SmallRng: "A small-state, fast non-crypto PRNG" Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Useful for experimentations... Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
544a49b to
2855c5b
Compare
Member
Author
|
Rebased on master after #10 merge. |
JSwambo
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #10 (itself base on #15 ...), see:
This adds an interface to fix #14 .
Good news: we can apparently support threshold-based managers set.
Question news: what now ?