Anti fee snipping: allow caller to set nLockTime to transactions#16
Merged
darosior merged 2 commits intorevault:masterfrom Sep 26, 2020
Merged
Anti fee snipping: allow caller to set nLockTime to transactions#16darosior merged 2 commits intorevault:masterfrom
darosior merged 2 commits intorevault:masterfrom
Conversation
Member
|
Ack 677f721 |
Benefits: - Enforce types at compilation - Better API (no Result at creation, errors are statics, more fine-grained) - Actual types (no enum variant) Drawbacks: - Boilerplate, partially handled by macros Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
677f721 to
cf19162
Compare
Member
Author
|
Rebased on master. ACK cf19162 (re-applying Jacob's ACK) |
darosior
added a commit
to darosior/revault_tx
that referenced
this pull request
Sep 28, 2020
This reverts commit f57f94d which was inadvertendly merged as part of revault#16 ... Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #15.
It adds a new parameter to the transactions constructor for them to be able to set the transaction's
nLockTime.