Codecov Report

Merging #998 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   53.91%   53.88%   -0.04%     
==========================================
  Files         116      114       -2     
  Lines       11000    11011      +11     
==========================================
+ Hits         5931     5933       +2     
- Misses       4391     4401      +10     
+ Partials      678      677       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550e1fe...a46baf7. Read the comment docs.

Should we run the tests with -race? maps aren't thread safe and I'm not 100% sure we cannot have multiple file listings in progress. aka, callbacks coming in from fuse.

Side note, this should be abstracted out, no? We now have multiple backends and cmd's where we are adding some form of caching to make things perform. Seems to me we should do this more central. For exmaple, I can imagine this commit not doing much on S3, as it already has a size cache...

Good points, but both aren't relevant here:

• Maps aren't thread safe, and multiple request from fuse can come in in parallel, that's both true. However, concurrent read from maps is thread safe, and we'll only create the size cache once (when the snapshots dir is constucted), and then it's read only access. So that's not an issue here.
• The map caches sizes for all blobs in the repo, the data is extracted from the index. The size cache for the s3 backend caches the size of files. It's a different level of abstraction. By the way: The size cache for the s3 backend is not used any more, and in one of the outstanding PRs I've already removed it completely.

I have plans for reworking the index data structures (also to address #979), maybe we can drop this particular cache then.

I've wrapped the cache in a struct and added a Lookup() method to make it clearer that the map is only queried, not changed concurrently.

Codecov Report

Merging #998 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   53.91%   53.86%   -0.06%     
==========================================
  Files         116      116              
  Lines       11000    11019      +19     
==========================================
+ Hits         5931     5935       +4     
- Misses       4391     4406      +15     
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550e1fe...a46baf7. Read the comment docs.