Extract snapshot data types from restic package#5525
Merged
MichaelEischer merged 3 commits intoOct 3, 2025
Conversation
1a301a7 to
e20cdb7
Compare
e20cdb7 to
70a24cc
Compare
MichaelEischer
commented
Oct 3, 2025
MichaelEischer
left a comment
Member
Author
There was a problem hiding this comment.
LGTM.
Sorry in advance to everyone caught in the incoming merge conflict fallout. 95% of all cases can be solved by keeping your change and just replacing restic with data in all places where the compiler/linter complains.
This was referenced Oct 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The restic package currently contains data types for two relatively independent parts of restic: the repository interface and the snapshot data types. Quite a while ago, I extracted the backend types from the restic package and untangled the remaining code. To wrap up this refactoring, move the snapshot data types into a new package called
data. This ensures that the different layers of restic remain decoupled from each other.The change itself is unfortunately one mega-commit, but slicing the change into smaller parts introduces unnecessary churn as it requires temporary import changes that have to be reverted later on.
Was the change previously discussed in an issue or on the forum?
Follow up to #4499 .
Checklist
[ ] I have added tests for all code changes.[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).