Split backend code from restic package#4499
Merged
MichaelEischer merged 6 commits intoOct 27, 2023
Merged
Conversation
de9f38f to
0509577
Compare
7af93e5 to
5a6c630
Compare
This removes code that is only used within a backend implementation from the backend package. The latter now only contains code that also has external users.
Ideally, code that uses a repository shouldn't directly interact with the underlying backend. Thus, move MemorizeList one layer up.
5a6c630 to
2496058
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The restic package is currently a big bunch of partially related code. In particular, it contains backend, repository and data format specific code. This makes it tempting to create leaky abstractions that expose internals of the repository format which should rather be encapsulated.
This PR splits the backend code from the restic package to provide a cleaner separation. There is still a significant amount of code that (unnecessarily) reaches into the backend of a repository.
Was the change previously discussed in an issue or on the forum?
No.
Checklist
[ ] I have added tests for all code changes.[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.