Skip to content

fix: Windows VSS Event ID 8194#5170

Merged
MichaelEischer merged 5 commits intorestic:masterfrom
Snshadow:fix-vss-8194
Jan 26, 2025
Merged

fix: Windows VSS Event ID 8194#5170
MichaelEischer merged 5 commits intorestic:masterfrom
Snshadow:fix-vss-8194

Conversation

@Snshadow
Copy link
Copy Markdown
Contributor

@Snshadow Snshadow commented Dec 2, 2024

What does this PR change? What problem does it solve?

Prevent Windows event 8194 log occurring when doing a backup with --use-fs-snapshot flag.

Was the change previously discussed in an issue or on the forum?

Closes #5169

Checklist

- [ ] I have added tests for all code changes.

  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I'm done! This pull request is ready for review.

@Snshadow Snshadow marked this pull request as draft December 2, 2024 03:20
- check if Windows version is previous 6.2(Windows 8)
@Snshadow Snshadow marked this pull request as ready for review December 3, 2024 02:25
Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a bit unclear in which situation exactly this change is necessary. Can this occur in default Windows setups? Does it require special user accounts etc.?

- remove fallback for previous Windows versions
- add more context for changelog
@Snshadow
Copy link
Copy Markdown
Contributor Author

Snshadow commented Jan 20, 2025

It's still a bit unclear in which situation exactly this change is necessary. Can this occur in default Windows setups? Does it require special user accounts etc.?

I have installed clean Windows 11(24H2) and it occurs if CoInitializeSecurity is not called in advance. The frequency of these logs varies depending on each execution.

sample

Looking into the comment from

/*
https://microsoft.public.win32.programmer.kernel.narkive.com/aObDj2dD/volume-shadow-copy-backupcomplete-and-vss-e-bad-state
, https://microsoft.public.win32.programmer.kernel.narkive.com/aObDj2dD/volume-shadow-copy-backupcomplete-and-vss-e-bad-state#post2
Looks like the occurrence of this event log has been noted before.

Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have installed clean Windows 11(24H2) and it occurs if CoInitializeSecurity is not called in advance. The frequency of these logs varies depending on each execution.

Thanks for checking!

I have a few more nits in the changelog, other than that the PR seem to be ready.

Copy link
Copy Markdown
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MichaelEischer MichaelEischer enabled auto-merge (squash) January 26, 2025 15:19
@MichaelEischer MichaelEischer merged commit 6301250 into restic:master Jan 26, 2025
@Snshadow Snshadow deleted the fix-vss-8194 branch January 27, 2025 04:58
@Snshadow Snshadow restored the fix-vss-8194 branch January 27, 2025 05:39
@Snshadow Snshadow deleted the fix-vss-8194 branch January 27, 2025 05:40
wplapper pushed a commit to wplapper/restic that referenced this pull request Feb 1, 2025
wplapper pushed a commit to wplapper/restic that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows VSS event ID 8194

3 participants