Fix VSS metadata error (v0.17.2)#5110
Merged
MichaelEischer merged 5 commits intorestic:patch-releasefrom Nov 3, 2024
Merged
Conversation
6f6a1bc to
7ad2601
Compare
rawtaz
approved these changes
Oct 31, 2024
26190d1 to
686ef71
Compare
Paths that only contain the volume shadow copy snapshot name require special treatment. These paths must end with a slash for regular file operations to work.
Extended attributes and security descriptors apparently cannot be retrieved from a vss volume. Fix the volume check to correctly detect vss volumes and just completely disable extended attributes for volumes.
686ef71 to
9622794
Compare
Member
Author
|
While working on #5112, I've noticed that the underlying root cause is different than expected. Apparently it makes a difference whether |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Fix VSS metadata error in restic 0.17.2, see #5107 for details.
Was the change previously discussed in an issue or on the forum?
Fixes #5107
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.