Fix VSS metadata error (master)#5112
Merged
MichaelEischer merged 10 commits intorestic:masterfrom Nov 3, 2024
Merged
Conversation
6970159 to
166a40a
Compare
Paths that only contain the volume shadow copy snapshot name require special treatment. These paths must end with a slash for regular file operations to work.
Extended attributes and security descriptors apparently cannot be retrieved from a vss volume. Fix the volume check to correctly detect vss volumes and just completely disable extended attributes for volumes.
fa8a144 to
51cd1c8
Compare
7 tasks
The test used \\?\GLOBALROOT\Device\HarddiskVolumeShadowCopy1 , which if it exists and supports extended attributes can cause the test to fail.
82658c1 to
289159b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Fix VSS metadata error, see #5107 for details.
Was the change previously discussed in an issue or on the forum?
Fixes #5107
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.