ui: restore --delete indicates number of deleted files#5100
Merged
MichaelEischer merged 4 commits intorestic:masterfrom Dec 1, 2024
Conversation
14b2932 to
a372d72
Compare
a372d72 to
30585cc
Compare
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
I have only one small nit remaining for the code. Besides that, please add a short changelog entry.
* adds new field `FilesDeleted` to the State struct, JSON and text progress updaters * increment FilesDeleted count when ReportedDeletedFile
30585cc to
66e5576
Compare
ui: report deleted directories and refactor function name to ReportDeletion changelog: issue-5092 lint: fix unused variable
2022c2e to
0d4e684
Compare
Snshadow
pushed a commit
to Snshadow/restic
that referenced
this pull request
Dec 2, 2024
* ui: restore --delete indicates number of deleted files * adds new field `FilesDeleted` to the State struct, JSON and text progress updaters * increment FilesDeleted count when ReportedDeletedFile * ui: collect the files to be deleted, delete, then update the count post deletion * docs: update scripting output fields for restore command ui: report deleted directories and refactor function name to ReportDeletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
FilesDeletedto the State struct, JSON and text progress updatersReportDeletedFiletoReportDeletionWas the change previously discussed in an issue or on the forum?
Closes #5092
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.