archiver: use FS interface nearly everywhere and cleanup exports#5023
Merged
MichaelEischer merged 9 commits intorestic:masterfrom Aug 31, 2024
Merged
archiver: use FS interface nearly everywhere and cleanup exports#5023MichaelEischer merged 9 commits intorestic:masterfrom
MichaelEischer merged 9 commits intorestic:masterfrom
Conversation
11 tasks
6b0444e to
6979457
Compare
6979457 to
8ba0310
Compare
Depending on parameters the paths in a snapshot do not directly correspond to real paths on the filesystem. Therefore, reject funcs must use the FS interface to work correctly.
With this change, NodeFromFileInfo is the last function that bypasses the FS interface in the archiver.
8ba0310 to
7bb92dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The include/exclude filters have moved to the archiver and filter packages to simplify their reuse. The archiver and its filters nearly always use the FS interface with
NodeFromFileInfobeing the last exception. Cleaning that up depends on #5022 .Was the change previously discussed in an issue or on the forum?
Part of #5021
Checklist
[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.