Extract filesystem code from restic.Node#5022
Merged
MichaelEischer merged 8 commits intorestic:masterfrom Aug 31, 2024
Merged
Conversation
11 tasks
8462649 to
c54a48b
Compare
This was referenced Aug 27, 2024
Merged
The code to write the file content is never used.
The temp files used by the packer manager are either delete after creation (unix) or marked as delete on close (windows). Thus, no explicit cleanup is necessary.
c54a48b to
507842b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
First part of #5021 . Reviewing the PR only makes sense commit by commit.
I'm not done yet with the cleanups, however, this PR is already far too large.
Was the change previously discussed in an issue or on the forum?
See #5021
Checklist
[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.