Improve handling of temporary files on windows#3610
Merged
fd0 merged 3 commits intorestic:masterfrom Apr 10, 2022
Merged
Conversation
89d5cf9 to
2a73af6
Compare
2a73af6 to
b10dcb8
Compare
6 tasks
Contributor
|
FILE_ATTRIBUTE_TEMPORARY and FILE_FLAG_DELETE_ON_CLOSE are both available in golang.org/x/sys/windows. That also offers everything now imported from syscall. |
b10dcb8 to
02852be
Compare
02852be to
00a3464
Compare
fd0
requested changes
Apr 9, 2022
2d2abe4 to
dbd245e
Compare
dbd245e to
4077a81
Compare
6 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
restic currently uses
ioutil.TempFile(...)to create its temporary files on Windows. As files cannot be deleted on Windows while these are still opened, restic sometimes leaves temporary files behind. This PR sets the FILE_FLAG_DELETE_ON_CLOSE flag to let windows delete the file automatically once all references were deleted. In addition, the flag FILE_ATTRIBUTE_TEMPORARY is added to avoid unnecessary writes of the temporary files to disk.As
os.Openand thereforeioutil.TempFiledo not support these flags, this PR introduces a customTempFileimplementation, that directly callssyscall.CreateFile.This PR is based on the code from @ducalex in #3465.
The temporary file is also created using shareMode 0, which prevents other processes from accessing the file in parallel. Thus restic is the only process which can open the file. As it will be deleted on close, this ensures that a tempfile can be removed, which fixes #1551.
Was the change previously discussed in an issue or on the forum?
Closes #3465.
Closes #1551.
Supersedes #3306.
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.