Failing to remove temporary file will result in debug warning#3306
Closed
jakubberkop wants to merge 2 commits intorestic:masterfrom
Closed
Failing to remove temporary file will result in debug warning#3306jakubberkop wants to merge 2 commits intorestic:masterfrom
jakubberkop wants to merge 2 commits intorestic:masterfrom
Conversation
Member
|
I think we should implement the approach from #3465 instead. It has the big benefit of handing the responsibility of deleting the temporary file to the operation system. |
7 tasks
Member
|
PR #3610 implements the os-managed temp files, so we'll use that one instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR fixes errors when creating backups on windows.
Sometimes another process (typically antivirus software) would block deleting temporary files, causing error, which should just be warnings.
This PR degrades those errors to warnings.
I have successfully tested this solution on multiple windows machines, which previously could not finish creating backup.
Was the change discussed in an issue or in the forum before?
Issues was discussed in #1551
https://forum.restic.net/t/temp-file-errors-on-windows-10/380/12
Checklist
gofmton the code in all commits