Use "pack file" instead of "data file"#2885
Conversation
- changed variable names, especially changed DataFile into PackFile - changed in some comments - always use "pack file" in docu
|
The change is also needed within #2718 - I used "data files" there and were wondering if that was confusing... |
|
I wonder if there are any or many PRs that will have to be updated if we merge this one first? If so, it might be best to put this on ice until after merging the other ones. |
|
I assume that this doesn't affect many PRs directly, but may produce easy-to-solve merge conflicts if "nearby" lines are changed. From my PRs - as far as I can see - only #2718 and #2543 should be affected. I would argue that this PR could be used immediately as potential merge conflicts of other PRs will not arise or be easy to solve. |
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. I've thought a bit about whether to merge this now or later on. Besides a few comment and doc changes everything else will lead to a compiler error if the name change is lost during a merge. The few merge conflicts that could arise should also be rather simple to resolve. So I think it's preferential to merge this PR just now rather than wait.
- changed variable names, especially changed DataFile into PackFile - changed in some comments - always use "pack file" in docu
What does this PR change? What problem does it solve?
Clarify code and documentation by using "pack file" or "pack" everywhere. In some places "data file" was used. This was a bit irritating as there are also data and tree blobs and pack which contain only data blobs or only tree blobs, respectively.
Was the change discussed in an issue or in the forum before?
closes #2877
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits