Extract get used blobs in prune as separate function#2841
Extract get used blobs in prune as separate function#2841MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
e482ec9 to
e1018d9
Compare
This is not intended; however I rebased this to an old version of #2840; so yes, it is still included. However, I can change this.
After #2599 is merged this in fact is no longer an optimization. I just extracted the functionality "get used blobs of all given snapshots and print a progress bar). The reason is that #2718 still uses this functionality, however directly at the beginning. Extracting it into a function IMO makes the new prune implementation easier to read. |
e1018d9 to
9762bec
Compare
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the cleanup.
Extracting it into a function IMO makes the new prune implementation easier to read.
Not just your new implementation. pruneRepository is already a way too long function, so extracting small independent parts helps.
|
Directly looking at travis shows that the CI run was completed successfully. So I'll just ignore that it still shows as 'in progress'. |
What is the purpose of this change? What does it change?
Put getting used blob within prune into a separate function
Was the change discussed in an issue or in the forum before?
This is a part of #2718 that can be merged independently.
Checklist
changelog/unreleased/that describes the changes for our users (template here) - is this needed?gofmton the code in all commits