Merged
Conversation
This was referenced Jul 19, 2020
Contributor
Author
|
The CI test failed another time due to the rclone problem... |
aawsome
added a commit
to aawsome/restic
that referenced
this pull request
Jul 25, 2020
Contributor
Author
|
Ups - does AppVeyor have a problem connecting github? |
aawsome
added a commit
to aawsome/restic
that referenced
this pull request
Jul 27, 2020
aawsome
added a commit
to aawsome/restic
that referenced
this pull request
Jul 27, 2020
aawsome
added a commit
to aawsome/restic
that referenced
this pull request
Jul 29, 2020
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
Sorry for another round of small changes, but I noticed a few more necessary changes while taking a closer look at the console output.
The current changes to the forget command have the side-effect of changing the semantics of the JSON output. As I don't see that the new semantic has a big benefit over the old one, I'd like to not break compatibility and keep the old behavior of only printing the JSON groups after the snapshots were deleted. So please change the error handling behavior for the JSON output back to the old one.
7780665 to
0eb8553
Compare
Merged
8 tasks
mfrischknecht
pushed a commit
to mfrischknecht/restic
that referenced
this pull request
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
parallelize deletion of files in
prune,forgetandrebuild-index. Also adds a progress bar for the deletion.Was the change discussed in an issue or in the forum before?
This is a part of #2718 that can be merged independently
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits