Merged
Conversation
7 tasks
Contributor
|
This seems like a better implementation then what I had, so +1 from me! I had two thoughts while I was taking a look over it:
Otherwise I ran the micro benchmarks locally here, and as expected they run much faster. Everything else looks good, and a quick grep through the code suggests no tricky logging statements were missed. |
Member
Author
|
Yeah, we can improve the benchmarks. I'll have a look later. |
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
==========================================
- Coverage 51.76% 51.62% -0.15%
==========================================
Files 142 142
Lines 11283 11283
==========================================
- Hits 5841 5825 -16
- Misses 4525 4546 +21
+ Partials 917 912 -5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in here optimizes debug.Log() calls when a restic ID is passed in. Before, the "shorten the string" method Str() was always called, which led to a function call and allocations happening even without the
debugtag. Now, we're calling theStr()method via reflection on demand in the debug code, which is only active with thedebugtag.Idea by @MJDSys in #1549