Fixed non rotatable devices rotating when "Rotate All" button in top of GUI is pressed#1439
Merged
manojVivek merged 4 commits intoresponsively-org:mainfrom Oct 31, 2025
Merged
Conversation
…utton-- rotation on individual devices still rotates regardless of device properties
|
|
manojVivek
requested changes
Oct 27, 2025
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
Thank you for taking this up, just some minor feedback.
Contributor
Author
|
Please re-review @manojVivek |
manojVivek
approved these changes
Oct 31, 2025
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
Thank you for the followup, pushed a tiny commit and it is all looking good now! 🎉
Collaborator
|
@all-contributors Please add @mklikushin for code. |
Contributor
|
I've put up a pull request to add @mklikushin! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fixes: #1438
ℹ️ About the PR
🖼️ Testing Scenarios / Screenshots
Clicked the rotate devices button and Macbook Pro no longer rotates, new devices with no touch or mobile also do not rotate.