Skip to content

Conversation

@aufdenkampe
Copy link
Collaborator

This PR adds a number of files to the tests folder:

This PR is work towards Expand & automate testing system #31.

@rheaphy and @steveskrip, lets use this PR "conversation" and our develop branches to share and align our testing folder structures and code, and figure out why some of LimnoTech's UCI files aren't reading.

aufdenkampe and others added 3 commits April 19, 2020 12:54
From @rheaphy, plus old Python2 notebooks that might be helpful to look over as we develop Python 3 versions We'll delete these eventually when we have Python 3 versions. Similar to 9ac41c7, but on our new develop branch.
Added Plaster Creek and West Indian test HSPF files to tests folder. Not useable in HSP2 yet.
@aufdenkampe aufdenkampe requested a review from rheaphy May 19, 2020 12:08
Emailed by @rheaphy on 2020-04-29 along with comments saved to respec#32 (comment)
Update from @rheaphy 2020-05-14 email.
Connects to respec#34
@aufdenkampe
Copy link
Collaborator Author

The latest update to TESTcalleg.html in 9882d83 was dated 2020-05-12 and is from @rheaphy's email two days later with this info:

Yesterday morning I updated the HSPsquared GitHub main branch repository. For the Calleg test case, PWATER is now as accurate as in HSPF (worst case was 0.0003 percent difference or almost exact to 6 significant digits) and RCHRES HYDR improved so the worst case is 0.0207 percent difference. IWATER was already an exact match to HSPF to single precision accuracy.

I found the two bugs when testing HSP2 for indelt times under 1 hour. I am still improving my testing to insure HSP2 works at any reasonable indelt. (I am currently testing 5 hour and 20 minute along with the original I hour tests.

Addresses respec#35.
Also reverses addition of `*.ipynb` to `.gitignore`, which @rheaphy used as a temporary solution to merge conflicts.
@aufdenkampe
Copy link
Collaborator Author

@rheaphy, my
Git-track Jupyter notebooks at binary commit LimnoTech@32c93ef should now allow us to use this repo to exchange the Jupyter notebooks that are an essential component of #31. Please let us know if this works. It would be great to get your latest TESTcalleg.ipynb and other notebooks.

@rheaphy rheaphy merged commit 436e3be into respec:develop May 22, 2020
rburghol pushed a commit to HARPgroup/HSPsquared that referenced this pull request Mar 5, 2025
Update from @rheaphy 2020-05-14 email.
Connects to respec#34
PaulDudaRESPEC pushed a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants