Move to single python package "hsp2" #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timcera
commented
May 22, 2024
- Moved the HSP2, HSP2IO, and HSP2tools top level packages to hsp2.hsp2, hsp2.hsp2io, and hsp2.hsp2tools respectively.
- Corrected the imports in python and Jupyter notebooks to use the new locations.
- HSP2 can be run in all of the CompareHSP2.ipynb in tests/, however some do not have the HSPF results to compare to.
- The Jupyter notebooks in examples/ need some work to find input data and where to write output.
* Moved the HSP2, HSP2IO, and HSP2tools top level packages to hsp2.hsp2, hsp2.hsp2io, and hsp2.hsp2tools respectively. * Corrected the imports in python and Jupyter notebooks to use the new locations. * HSP2 can be run in all of the CompareHSP2.ipynb in tests/, however some do not have the HSPF results to compare to. * The Jupyter notebooks in examples/ need some work to find input data and where to write output.
rburghol
pushed a commit
to HARPgroup/HSPsquared
that referenced
this pull request
Mar 5, 2025
Move to single python package "hsp2" Nice work, thanks @timcera !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.