Initial SPECL.py PR #104
Merged
Initial SPECL.py PR #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdkleiner
commented
Oct 19, 2022
- Cleaned up comments and added draft specl error infrastructure
PaulDudaRESPEC
approved these changes
Jan 11, 2023
Member
PaulDudaRESPEC
left a comment
There was a problem hiding this comment.
This looks great -- looks like you caught a few details related to OS for each exit too. I notice there is a good bit of commented out code for testing -- we'll probably want to remove that before merging into the master eventually. Thanks for the contributions!
Contributor
Author
|
@PaulDudaRESPEC Excellent, thank you for merging! Understood on the commented out testing code, we have a current development copy that we're working on at the moment that is a bit more tidy. Looking forward to pushing some more updates soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.