send presence mechanism through PUBLICATION message#52
send presence mechanism through PUBLICATION message#52dpocock merged 1 commit intoresiprocate:masterfrom
Conversation
resip/dum/BaseCreator.cxx
Outdated
|
|
||
| if(method == SUBSCRIBE) | ||
| { | ||
| mLastRequest->header(h_Accepts).push_back( Mime( "application","pidf+xml") ); |
There was a problem hiding this comment.
can you move this line into resip/dum/SubscriptionCreator.cxx please
91e9d34 to
3e560b1
Compare
resip/dum/SubscriptionCreator.cxx
Outdated
|
|
||
| mLastRequest->header(h_Event).value() = event; | ||
| mLastRequest->header(h_Expires).value() = subscriptionTime; | ||
| mLastRequest->header(h_Accepts).push_back( Mime( "application","pidf+xml") ); |
There was a problem hiding this comment.
This change is not appropriate - you can't add that Accept header to all subscriptions created by DUM.
There was a problem hiding this comment.
So is there a specific condition that must be satisfied to add the Accept header?
There was a problem hiding this comment.
@MateusBellomo remove the change from SubscriptionCreator and try using addSupportedMimeType(NOTIFY, Pidf::getStaticType()) on the MasterProfile in your apps/telepathy code in pull request #53. Does that sound correct @sgodin ?
There was a problem hiding this comment.
Yup :)
On Thu, Aug 11, 2016 at 3:33 AM, Daniel Pocock notifications@github.com
wrote:
In resip/dum/SubscriptionCreator.cxx
#52 (comment):@@ -15,6 +15,7 @@ SubscriptionCreator::SubscriptionCreator(DialogUsageManager& dum,
mLastRequest->header(h_Event).value() = event; mLastRequest->header(h_Expires).value() = subscriptionTime;
- mLastRequest->header(h_Accepts).push_back( Mime( "application","pidf+xml") );
@MateusBellomo https://github.com/MateusBellomo remove the change from
SubscriptionCreator and try using addSupportedMimeType(NOTIFY,
Pidf::getStaticType()) on the MasterProfile in your apps/telepathy code
in pull request #53 #53.
Does that sound correct @sgodin https://github.com/sgodin ?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/resiprocate/resiprocate/pull/52/files/3e560b1c7f1fd67ba053d282961fd40561059262#r74378435,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACtNUV1kSOkmVGpqZawOGsouTDfJ2WZ0ks5qetBdgaJpZM4JYfsi
.
3e560b1 to
097a0f5
Compare
| /* ==================================================================== | ||
|
|
||
| Copyright (c) 2007-2008, Plantronics, Inc. | ||
| Mateus Bellomo (mateusbellomo AT gmail DOT com) https://mateusbellomo.wordpress.com/ |
There was a problem hiding this comment.
@MateusBellomo please start this line with "Copyright (C) 2016, " before your name, same for the hxx file
097a0f5 to
14ca60a
Compare
changes at resip/dum, resip/recon and resip/stack APIs to enable sending a PUBLICATION message.