send/receive text message mechanism through MESSAGE message#53
Merged
dpocock merged 1 commit intoresiprocate:masterfrom Aug 17, 2016
Merged
send/receive text message mechanism through MESSAGE message#53dpocock merged 1 commit intoresiprocate:masterfrom
dpocock merged 1 commit intoresiprocate:masterfrom
Conversation
50c03eb to
9e3b4ac
Compare
resip/recon/ConversationManager.cxx
Outdated
| } | ||
| if(!mUserAgent->mDum.getMasterProfile()->isMimeTypeSupported(MESSAGE, mimeType)) | ||
| { | ||
| mUserAgent->mDum.getMasterProfile()->addSupportedMimeType(MESSAGE, mimeType); |
Member
There was a problem hiding this comment.
we shouldn't do this here in recon, the application developer needs to decide which MIME types they want to support so please remove this
9e3b4ac to
709eaf7
Compare
2fda6b2 to
edd70bd
Compare
| UserAgent::sendMessage(const NameAddr& destination, const Data& msg, const Mime& mimeType) | ||
| { | ||
| if(!mDum.getMasterProfile()->isMethodSupported(MESSAGE)) | ||
| { |
Member
There was a problem hiding this comment.
if MESSAGE wasn't already in the MasterProfile, we wouldn't be able to receive MESSAGE requests. Please log a warning message here when this scenario is detected.
Contributor
Author
There was a problem hiding this comment.
but this function is for sending messages, it would get here when a MESSAGE is received?
edd70bd to
3165966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes at resip/recon API to enable send and receive MESSAGE messages.