Use the same arrow_ui function everywhere
#8590
Conversation
6147276 to
ab046ff
Compare
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| @@ -0,0 +1,136 @@ | |||
| /// Specifies the context in which the UI is used and the constraints it should follow. | |||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | |||
| pub enum UiLayout { | |||
There was a problem hiding this comment.
This has just moved from crates/viewer/re_viewer_context/src/component_ui_registry.rs
abey79
left a comment
There was a problem hiding this comment.
lgtm but I'm really unsure about the use of monospace font for "summary" text (as opposed to actual data).
Also, make sure existing snapshot test pass—pretty sure some are invalidated, especially test_all_components_ui.rs.
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12638038182 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12638234271 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12638835037 |
### Related * Follow-up to #8590 * Part of #3741 * ~Blocked on apache/arrow-rs#6951 ### What Uses `arrow-rs` own formatting of arrow values. Unfortunately this adds a `.0` suffix to all integer floating point values, which makes them quite verbose. I will see if there is a way around that.
Related
re_arrow2toarrow#3741What
Unify how we show arbitrary arrow data in our UI, and add a test for it.
This is mostly a refactor, but may change behavior slightly.