Skip to content

Add components for RotationAxisAngle and RotationQuat#6929

Merged
Wumpf merged 15 commits intomainfrom
andreas/new-rotation-components
Jul 22, 2024
Merged

Add components for RotationAxisAngle and RotationQuat#6929
Wumpf merged 15 commits intomainfrom
andreas/new-rotation-components

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Jul 17, 2024

What

Very similar to previous PRs in the series. Still doesn't remove existing components since Transform3D datatype is still used in OutOfTreeTransform and the Transform3D datatype is still used to describe from_parent (that's the next thing to fix!)

Checklist

  • don't regress main checks further
  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🍏 primitives Relating to Rerun primitives include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Jul 17, 2024
@Wumpf Wumpf force-pushed the andreas/new-rotation-components branch from 97a6544 to 9107d74 Compare July 17, 2024 18:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 17, 2024

Deployed docs

Commit Link
351e319 https://landing-o2rugsbh8-rerun.vercel.app/docs

@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented Jul 18, 2024

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9989638328

@Wumpf Wumpf mentioned this pull request Jul 18, 2024
7 tasks
@Wumpf Wumpf force-pushed the andreas/new-rotation-components branch from 30fa07a to ca77d64 Compare July 19, 2024 08:34
@teh-cmc teh-cmc self-requested a review July 22, 2024 07:20
@Wumpf Wumpf added the do-not-merge Do not merge this PR label Jul 22, 2024
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jul 22, 2024
@Wumpf Wumpf merged commit 9c26c5a into main Jul 22, 2024
@Wumpf Wumpf deleted the andreas/new-rotation-components branch July 22, 2024 09:41
Wumpf added a commit that referenced this pull request Jul 22, 2024
### What

* Based on  #6929
* Important milestone towards #6831
    * only missing the planned out of tree handling
    * and some other related tickets .. ;)
* Fixes #6863
* created follow-up issue for the aliases which I didn't get to:
#6943

Automated test + test again planet system

![image](https://github.com/user-attachments/assets/15dbda23-7b62-432a-a4a8-cfacf448c2a8)

Still need some more test & a checklist for this blob of changes, as
well as a more thorough pass on the migration guide!

### Checklist
* [x] main checks
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6944?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6944?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/6944)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🍏 primitives Relating to Rerun primitives

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants