Conversation
6 tasks
Contributor
Deployed docs
|
6 tasks
c919adb to
9c17ccc
Compare
archetype.ImageEncodedImageChromaDownsampled to Python LOG API
ImageChromaDownsampled to Python LOG APIImageChromaDownsampled
1 task
6 tasks
ImageChromaDownsampledImageChromaDownsampled
Wumpf
approved these changes
Jul 15, 2024
Member
Wumpf
left a comment
There was a problem hiding this comment.
onwards! :)
Obviously not blocking on this since ImageChromaDownsampled is meant to be temporary as well, but I really hope we can get away without any of these pseudo archetypes at the end of this :)
Comment on lines
-21
to
-45
| BMP: ImageFormat | ||
| """ | ||
| BMP file format. | ||
| """ | ||
|
|
||
| GIF: ImageFormat | ||
| """ | ||
| JPEG/JPG file format. | ||
| """ | ||
|
|
||
| JPEG: ImageFormat | ||
| """ | ||
| JPEG/JPG file format. | ||
| """ | ||
|
|
||
| PNG: ImageFormat | ||
| """ | ||
| PNG file format. | ||
| """ | ||
|
|
||
| TIFF: ImageFormat | ||
| """ | ||
| TIFF file format. | ||
| """ | ||
|
|
Member
There was a problem hiding this comment.
from a python user's pov this will now look like we support fewer formats. We need to write something in the changelog/migration guide to clarify what's happening 🤔
Also we should probably enable gif, bmp and tiff support as well
| *, | ||
| path: str | pathlib.Path | None = None, | ||
| contents: datatypes.BlobLike | None = None, | ||
| contents: bytes | IO[bytes] | datatypes.BlobLike | None = None, |
Member
There was a problem hiding this comment.
BlobLike should probably contain the IO[bytes] alias? This can be done in its fbs definition with the right python attribute
emilk
added a commit
that referenced
this pull request
Jul 15, 2024
### What * Part of #6844 * Next PR: #6874 * Next +1: #6883 (where we rename it to `ImageChromaDownsampled`) * Next +2: #6884 This is a temporary measure to make room for a new `archetypes.ImageEncoded` without name collision. I plan to remove `ImageEncodedHelper` fully before 0.18. `ImageEncodedHelper` handles both image files (JPEG, PNG, …) and chroma sub-sampled data (NV12, YUY2). In the new design, the former will be handled by `ImageEncoded`, but chroma-subsampled images will be stored directly as `Image`s, with a special `PixelFormat`. This means that once 0.18 is done, only users using chroma subsampling will have to update their code. I'll make sure the new `ImageEncoded` archetype ctor supports all of the same parameters as the old helper, so that there are helpful runtime error messages for our users. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6882?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6882?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6882) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
9cd1305 to
34efa0d
Compare
emilk
added a commit
that referenced
this pull request
Jul 15, 2024
) ### What * Part of #6844 * Part of #3803 Has `do-no-merge` because of current merge-target. ### PR train * Prev: #6882 * Next: #6883 * Next: #6884 ### Coming in follow-up PRs: * Fix image picking, hovering, and visualization in spatial view * Switch to using `ImageEncoded` in all examples * Remove old code for storing JPEGs in tensors ### Fixes * Fixes #6520 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6874?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6874?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6874) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Andreas Reich <andreas@rerun.io>
An error occurred while trying to automatically change base from
emilk/image-encoded
to
main
July 15, 2024 10:11
209e0d2 to
b54fbbd
Compare
emilk
added a commit
that referenced
this pull request
Jul 15, 2024
…e` (#6884) * Part of #6844 * Closes #3803⚠️ This breaks any existing `JPEG`-encoded RRDs ### Rust API * Removed `TensorBuffer::JPEG` * Removed `TensorData::from_jpeg_bytes` * Deprecated `Image::from_file_path` and `from_file_contents` For all of these, use `ImageEncoded` instead. ### PR train * Prev: #6882 * Prev: #6874 * Prev: #6883 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6884?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6884?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6884) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
ImageChromaDownsampledImageChromaDownsampled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TensorBuffer::JPEGwithImageEncodedarchetype #3803This switches us to use the new
archetype.ImageEncodedin all examples.Logging chroma-downsampled images (NV12/YUY2) is now done with the new
ImageChromaDownsampledhelper (which will probably go away before 0.18).PR train
ImageEncodedtoImageEncodedHelper#6882archetypes.ImageEncodedwith PNG and JPEG support #6874TensorBuffer::JPEG,DecodedTensor,TensorDecodeCache#6884Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.