Allow hiding/showing entity subtrees under shown/hidden parent tree#5508
Merged
Allow hiding/showing entity subtrees under shown/hidden parent tree#5508
Conversation
… on where to go from here
Member
Author
|
as per slack conversation the selection panel should be simplified again:
|
… mention that it was inherited
Member
Author
|
done: |
jleibs
approved these changes
Mar 14, 2024
| let override_source = | ||
| data_result.component_override_source(&query_result.tree, &Visible::name()); | ||
| let is_inherited = | ||
| override_source.is_some() && override_source.as_ref() != Some(entity_path); |
Contributor
There was a problem hiding this comment.
Do you not consider no override source to be inherited? It's sort of "inherited from the default"
Member
Author
There was a problem hiding this comment.
I was pondering that as well a bit but the mechanics are different in that far that we don't have a path to show for. Not sure!
Contributor
Size changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The title describes the main effect this has on what Rerun can do compared to the previous release. But the real star of the show is that visible is now a component, not part of
EntityProperties.@ reviewer: Please take your time and explore the behavior both on blueprint panel and selection panel, there's a surprising amount of nuance in here.
For instance there's extra logic for allowing you to go back to a clean slate with ui interactions - for instance hiding & unhiding an item that doesn't receive any parent overrides will remove the visibility override completely as the default value for visibility is 'true'.
You can now hide/show under a shown/hidden parent tree:
nuance.mp4
We're able to keep track of where an override comes from, this is exposed in the selection panels' tooltip:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io