Skip to content

Control panel expanded state via blueprint APIs#5484

Merged
jleibs merged 24 commits intomainfrom
jleibs/panel_apis
Mar 13, 2024
Merged

Control panel expanded state via blueprint APIs#5484
jleibs merged 24 commits intomainfrom
jleibs/panel_apis

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Mar 12, 2024 •
edited by github-actions bot
Loading

What

These replace the old python_bridge APIs.

Also plumb through some missing components:

  • Viewport.auto_space_view
  • Viewport.auto_layout
  • SpaceView.display_name

Updated the old python blueprint example now that the bridge APIs are gone.

Example code:

        blueprint = Blueprint(
            Viewport(
                Grid(
                    Spatial2D(name="Rect 0", origin="/", contents=["image", "rect/0"]),
                    Spatial2D(name="Rect 1", origin="/", contents=["image", "rect/1"]),
                ),
                auto_space_views=args.auto_space_views,
            ),
            BlueprintPanel(expanded=False),
            SelectionPanel(expanded=False),
            TimePanel(expanded=False),
        )

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs added 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 12, 2024
@jleibs jleibs marked this pull request as ready for review March 12, 2024 23:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Size changes

Name main 5484/merge Change
incremental_logging.rrd (none) 0.0 MiB +100%

@jleibs jleibs mentioned this pull request Mar 13, 2024
Merged
5 tasks
@Wumpf Wumpf self-requested a review March 13, 2024 08:22
Wumpf
Wumpf previously requested changes Mar 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff! there's a typo that needs fixing and I'd like to chat about the archetype structure

@jleibs jleibs dismissed Wumpf’s stale review March 13, 2024 19:26

addressed changes

@jleibs jleibs merged commit 05d2b98 into main Mar 13, 2024
@jleibs jleibs deleted the jleibs/panel_apis branch March 13, 2024 20:03
jleibs added a commit that referenced this pull request Mar 13, 2024
@jleibs
Allow rerun_py to be built without the viewer (#5485)
1a2b9e3 
### What
- Builds on top of: #5484

- Resolves: #2089
- Specifically the part about the bridge dep on re_viewer. The rest of
the decoupling has already been done.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5485/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5485/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5485/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5485)
- [Docs
preview](https://rerun.io/preview/5189590ca4dc0282a6b1c814200db8434ab7004e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/5189590ca4dc0282a6b1c814200db8434ab7004e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
This was referenced Mar 15, 2024
Closed
Closed
@emilk emilk changed the title Include blueprint APIs for controlling panel expanded state Control panel expanded state via blueprint APIs Apr 5, 2024
@emilk emilk added the 🪵 Log & send APIs Affects the user-facing API for all languages label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wumpf Wumpf Wumpf left review comments

Assignees

No one assigned

Labels

🟦 blueprint The data that defines our UI include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jleibs @Wumpf @emilk