Skip to content

Once semantics for setup_{web|native}_logging#4896

Merged
teh-cmc merged 3 commits intomainfrom
cmc/setup_logging_once
Jan 24, 2024
Merged

Once semantics for setup_{web|native}_logging#4896
teh-cmc merged 3 commits intomainfrom
cmc/setup_logging_once

Conversation

@teh-cmc
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc commented Jan 24, 2024

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 😤 annoying Something in the UI / SDK is annoying to use exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 24, 2024
@Wumpf Wumpf self-requested a review January 24, 2024 10:46
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much better! 👍

@teh-cmc teh-cmc merged commit 639b271 into main Jan 24, 2024
@teh-cmc teh-cmc deleted the cmc/setup_logging_once branch January 24, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup_native_logging needs to handle its own Once semantics

2 participants