Initial support for manually adding container and space view in the hierarchy#4616
Merged
Initial support for manually adding container and space view in the hierarchy#4616
Conversation
Disable container GC lint fix: add back ticks
- stop auto-simplify introduced by new Container blueprints - mark edited when running manual simplification
jleibs
reviewed
Dec 22, 2023
| .map(|entry| { | ||
| SpaceViewBlueprint::new( | ||
| entry.class.identifier(), | ||
| &format!("empty {}", entry.class.display_name()), |
Contributor
There was a problem hiding this comment.
Naming it "empty" immediately makes the name wrong as soon as you add content.
Maybe: "New {}"?
Better yet, we could make name optional -- if it's None then we could generate the name dynamically at runtime and otherwise we could use whatever the user has provided.
Member
Author
There was a problem hiding this comment.
This default naming is becoming annoying :) #4669
jleibs
approved these changes
Dec 22, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
I pushed a small mutabillity fix -- otherwise looks great.
jleibs
approved these changes
Dec 22, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
I pushed a small mutabillity fix -- otherwise looks great.
# Conflicts: # crates/re_viewer/src/ui/rerun_menu.rs # crates/re_viewer_context/src/app_options.rs # crates/re_viewport/src/viewport.rs # crates/re_viewport/src/viewport_blueprint.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is an initial take for the new so-called "additive workflow", which enables building a hierarchy of container and space views from scratch. It involves the following changes in UX:
This feature is gated behind an experimental flag (Rerun Menu -> Options -> Enable the container addition workflow).
This PR also reorganises the experimental flags in the rerun menu such that they are visible in web and release builds.(superseded by #4661)Fixes #4492
Fixes #4493
TODO (not necessarily in this PR)
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io