Standard input/output support 2: Rust SDK stdout impl/examples/docs#4512
Merged
Standard input/output support 2: Rust SDK stdout impl/examples/docs#4512
Conversation
This was referenced Dec 13, 2023
52d7156 to
c80d18b
Compare
c2b3750 to
634f7ff
Compare
4d7140a to
98d62d7
Compare
teh-cmc
commented
Dec 14, 2023
teh-cmc
commented
Dec 14, 2023
98d62d7 to
311322e
Compare
Wumpf
approved these changes
Dec 14, 2023
Member
Wumpf
left a comment
There was a problem hiding this comment.
Nice!!
Sample works well and is easy to understand
Comment on lines
+46
to
+48
| /// | ||
| /// `None` indicates stdout. | ||
| path: Option<PathBuf>, |
Member
There was a problem hiding this comment.
... you could also have used an enum that makes this more obvious than reinterpreting the meaning of None
Contributor
Author
There was a problem hiding this comment.
Eh, I'd have gone there if it was part of the API but it's just some private field for debugging; not worth it imo.
teh-cmc
added a commit
that referenced
this pull request
Dec 14, 2023
Add a `stdin` source to the viewer so it can stream data in from standard input. We make `stdin` an explicit input (`rerun -`) like in the good old days, to avoid shady behavior in non-TTY and other esoteric environment (crazy WSL setups, etc). Trust me, it gets quite insane... Checks: - [x] `rerun` works - [x] `rerun -` blocks - [x] `rerun - < data.rrd` works - [x] `cat data.rrd | rerun -` works - [x] `rerun < data.rrd` works but does nothing - [x] `cat data.rrd | rerun` works but does nothing - [x] no-TTY & other esoteric environments don't go completely off the rails --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
0198603 to
0ca0945
Compare
teh-cmc
added a commit
that referenced
this pull request
Dec 14, 2023
…4514) Allow the C++ SDK to stream RRD data to stdout. Checks: - [x] `just py-build && just cpp-build-examples && echo 'hello from stdin!' | ./build/debug/examples/cpp/stdio/example_stdio | rerun -` --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the Rust SDK to stream RRD data to stdout.
Checks:
just py-build && echo 'hello from stdin!' | cargo run -p stdio | rerun -Part of a small PR series to add stdio streaming support to our Viewer and SDKs:
Checklist