Merged
Conversation
…ssary Sync/Send restrictions
…to new egui_tiles ticket
emilk
approved these changes
Dec 10, 2023
Member
emilk
left a comment
There was a problem hiding this comment.
This is wonderful ⭐⭐⭐
I pushed a few commits to improve the puffin profiler output slightly, PTAL
crates/re_viewer_context/src/space_view/system_execution_output.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
thanks for those commits, much nicer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two levels of parallism actually:
This gives us major speedups whenever:
As such this is a very fundamental & widely applicable parallelization!
(a rather silly "points with arrows" scene duplicated a bunch of times. Note that we still don't have any caching, so all these space views might as well be animated individually!)
Related things that are not parallel yet:
Checklist
End of a series on refactors leading to this parallization: