Introduce exit_on_error and use this instead of throw_on_error everywhere#4081
Merged
Introduce exit_on_error and use this instead of throw_on_error everywhere#4081
exit_on_error and use this instead of throw_on_error everywhere#4081Conversation
emilk
approved these changes
Oct 30, 2023
emilk
approved these changes
Oct 30, 2023
emilk
added a commit
that referenced
this pull request
Oct 30, 2023
…erywhere (#4081) ### What Throwing doesn't look great especially on windows debug builds:  Thew new method gives a nice error when you start from command line: ``` build\Debug\example_dna.exe Expected env-var RERUN_STRICT to be 0/1 true/false yes/no on/off, found ''Rerun ERROR: Failed to find Rerun Viewer executable in PATH. You can install binary releases of the Rerun Viewer: * Using `cargo`: `cargo binstall rerun-cli` (see https://github.com/cargo-bins/cargo-binstall) * Via direct download from our release assets: https://github.com/rerun-io/rerun/releases/latest/ * Using `pip`: `pip3 install rerun-sdk` (warning: pip version has slower start times!) For more information, refer to our complete install documentation over at: https://rerun.io/docs/getting-started/installing-viewer ``` Also fixed typo in the C++ tutorial and added windows specific instructions ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4081) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4081) - [Docs preview](https://rerun.io/preview/7dcf776f91aae882c88e87fa1d0108bf63704728/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/7dcf776f91aae882c88e87fa1d0108bf63704728/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Throwing doesn't look great especially on windows debug builds:
Thew new method gives a nice error when you start from command line:
Also fixed typo in the C++ tutorial and added windows specific instructions
Checklist