Skip to content

Add scary warning that default recording_id = authkey#3799

Merged
teh-cmc merged 3 commits intomainfrom
cmc/new_recordings_issue
Oct 12, 2023
Merged

Add scary warning that default recording_id = authkey#3799
teh-cmc merged 3 commits intomainfrom
cmc/new_recordings_issue

Conversation

@teh-cmc
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc commented Oct 11, 2023 •
edited by github-actions bot
Loading

Rendered:
image

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 📖 documentation Improvements or additions to documentation sdk-python Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 11, 2023
jleibs
jleibs reviewed Oct 11, 2023
View reviewed changes
@teh-cmc teh-cmc force-pushed the cmc/new_recordings_issue branch from 6cf5a8e to 38bb053 Compare October 11, 2023 17:02
emilk
emilk reviewed Oct 12, 2023
View reviewed changes
@teh-cmc teh-cmc force-pushed the cmc/new_recordings_issue branch from 38bb053 to 026a603 Compare October 12, 2023 07:12
@teh-cmc teh-cmc merged commit 2cada94 into main Oct 12, 2023
@teh-cmc teh-cmc deleted the cmc/new_recordings_issue branch October 12, 2023 07:28
emilk pushed a commit that referenced this pull request Oct 12, 2023
@teh-cmc @emilk
Add scary warning that default recording_id = authkey (#3799)
b02bb5e 
Rendered:

![image](https://github.com/rerun-io/rerun/assets/2910679/645c216b-488a-4ef5-9627-e476bb29e8e7)

- Fixes #3798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

+1 more reviewer

@jleibs jleibs jleibs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md sdk-python Python logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make sure the default recordingid / authkey() business is properly documented

3 participants

@teh-cmc @emilk @jleibs