Skip to content

Introduce AsComponents in Rust#3482

Merged
teh-cmc merged 12 commits intomainfrom
cmc/rust_ascomponents
Sep 27, 2023
Merged

Introduce AsComponents in Rust#3482
teh-cmc merged 12 commits intomainfrom
cmc/rust_ascomponents

Conversation

@teh-cmc
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc commented Sep 26, 2023 •
edited by github-actions bot
Loading

Implement new AsComponents trait, which is now in charge of all the data/batch serialization management.
This makes it easier to work with custom data: see the updated example of the same name.

Also stop generating try_to_arrow while we're at it.

What

Checklist

@teh-cmc teh-cmc added 🏹 arrow Apache Arrow sdk-rust Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) labels Sep 26, 2023
@teh-cmc teh-cmc changed the base branch from main to cmc/splatted_indicators September 26, 2023 16:03
@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Sep 26, 2023
@teh-cmc teh-cmc force-pushed the cmc/rust_ascomponents branch from f9a39b1 to 8042ec2 Compare September 26, 2023 16:07
@jleibs jleibs requested review from jleibs and removed request for jleibs September 26, 2023 16:35
emilk
emilk requested changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup, but please remove that panicking function. We don't like panics.

@teh-cmc teh-cmc force-pushed the cmc/splatted_indicators branch from 95f65b3 to 871eb8c Compare September 27, 2023 07:39
Base automatically changed from cmc/splatted_indicators to main September 27, 2023 08:05
@teh-cmc teh-cmc force-pushed the cmc/rust_ascomponents branch 2 times, most recently from 0fe1649 to 42dc3a2 Compare September 27, 2023 08:55
@teh-cmc teh-cmc enabled auto-merge (squash) September 27, 2023 08:56
@teh-cmc teh-cmc requested a review from emilk September 27, 2023 08:56
emilk
emilk reviewed Sep 27, 2023
View reviewed changes
@teh-cmc teh-cmc force-pushed the cmc/rust_ascomponents branch from 292e269 to 83e0266 Compare September 27, 2023 11:27
@teh-cmc teh-cmc requested a review from emilk September 27, 2023 11:27
@teh-cmc teh-cmc merged commit 099b946 into main Sep 27, 2023
@teh-cmc teh-cmc deleted the cmc/rust_ascomponents branch September 27, 2023 11:34
@teh-cmc teh-cmc mentioned this pull request Sep 27, 2023
Merged
3 tasks
teh-cmc added a commit that referenced this pull request Sep 27, 2023
@teh-cmc
Fix Archetype::from_arrow runtime mapping of fields<->components (#…
736c8fe 
…3496)

Regression introduced by #3482 which somehow got it because Github's
auto-merge is... not great.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

🏹 arrow Apache Arrow 🧑‍💻 dev experience developer experience (excluding CI) do-not-merge Do not merge this PR sdk-rust Rust logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reimplement Archetype::try_to_arrow in terms of as_component_batches Implement new AsComponents trait/protocol

2 participants

@teh-cmc @emilk