C++ custom result type used for serialization results#3005
Merged
Conversation
emilk
approved these changes
Aug 16, 2023
rerun_cpp/src/rerun/status.cpp
Outdated
| code = StatusCode::ArrowStatusCode_AlreadyExists; | ||
| break; | ||
| default: | ||
| code = StatusCode::Unknown; |
Member
There was a problem hiding this comment.
Suggested change
| code = StatusCode::Unknown; | |
| code = StatusCode:: ArrowStatusCode_Unknown; |
Member
Author
There was a problem hiding this comment.
I'd argue that's different - we don't know if it's an error unknown, instead it is an error that we literally don't know about
e0a839c to
370bb25
Compare
8872e2d to
036d6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces a very simple
rerun::Result. I decided to keep it a lot more simple than the arrow Result type and refrained from the typical "return or assign" etc. macro since I noticed that they get quite complicated quickly.The idea is that the rerun result type won't be needed by a lot of manual code, so erring on the too lightweight side should be in our favor.
We use this now accross the entire public serialization path - meaning that once we move out array->arrow serialization helper into separate headers we should be pretty much done with not exposing arrow headers!
Checklist