Skip to content

Zoom timeline#3

Merged
emilk merged 14 commits intomainfrom
zoom-timeline
Apr 19, 2022
Merged

Zoom timeline#3
emilk merged 14 commits intomainfrom
zoom-timeline

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Apr 19, 2022

This makes a major refactor of the time area and other things, in order to support zooming and panning of the time area.

@emilk emilk merged commit a1973aa into main Apr 19, 2022
@emilk emilk deleted the zoom-timeline branch April 19, 2022 09:29
teh-cmc added a commit that referenced this pull request Dec 2, 2022
teh-cmc added a commit that referenced this pull request Dec 5, 2022
* object path => entity path

* move utils from lib.rs to dedicated file

* color_rgba -> color_srgba_unmultiplied

* getting intimate with arrow's datamodel

* getting _even more_ intimate with arrow's datamodel

* split it

* building dem index keys

* disgustingly, incorrectly inserting components all the way down

* timelines need no list

* similarly clarifying the nested listing situation, on the components side this time

* make sure it looks like it should!

* actual integration tests

* bootstrapping text-based debugging

* bootstrapping indices

* introducing TypedTimeInt everywhere

* full index sorting

* auto-inserting empty component lists in starting buckets

* better datagen tools

* bidirectional merges for indices + properly showing NULLs in dataframes

* finally can show off some more advanced ingestion patterns!

* dealing with corrupt validity bitmaps, and the sheer size of my stupidity

* read path taking its first steps: latest_at for indices!

* look! it's a read path!

* it works!

* show the resulting dataframe duh

* clean up pass #1: task log

* clean up pass #2: moving everybody where they belong

* clean up pass #3: definitions

* a minimal solution for missing components

* some more cleanup

* porting relevant TODOs into issues

* appeasing the CI deities

* merge catastrophe

* they see me cleanin', they hatin'

* * Reorg of re_arrow_store
* Removed up old ArrowDB code
* Connected app data ingest into new DataStore

* fix broken doc links

* store files prefixed with store_

* integration tests in integration folder + exposing datagen tools to everyone

* make integration tests scale to more complex scenarios

* adding currently failing scenario: query before any data present

* added failing test and scenarios for all emptines-related edge cases

* better testing tools

* fixing broken edge cases on read path

* demonstrating faulty read behavior in roundtrip test

* fixing dem faulty swaps

* when the doc itself demonstrates bugs :x

* adding baseline bench somewhat mimicking the legacy ones, though it doesn't really make sense anymore

* exploding query results so you can actually do stuff with them

* properly testing all halfway frames (and, unsurprisingly, failing!)

* properly dealing with multi-row primary indices

* less verbose scenarios for end-to-lend latest_at tests

* addressing misc PR comments

* TimeReal, TimeRange & TimeRangeF are now a properly of re_log_types™

* retiring TypedTimeRange before Emil tries to hurt it

* mark unreachable as such

* replaced binary_search with a partition_point

* using entity path hashes directly in indexing datastructures

* re_viewer don't need those no more

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@emilk emilk mentioned this pull request Jan 24, 2023
grtlr added a commit that referenced this pull request Nov 19, 2024
jleibs-repo-sync-test bot referenced this pull request in jleibs/rerun Dec 10, 2025
Fetch the rerun PR body (which mirrors the universe PR description) and
use it as the squash merge commit body, appending only the Source-Ref
trailer.

Source-Ref: a95316d96e59fa162cd4315fa5ea96c0873bc1f5
jleibs added a commit that referenced this pull request Dec 18, 2025
- Updated P12 plan with completed items #3 and #4
- Updated WORK.md with Phase 1-3 completion status

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
jleibs added a commit that referenced this pull request Dec 19, 2025
- Updated P12 plan with completed items #3 and #4
- Updated WORK.md with Phase 1-3 completion status

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
jleibs added a commit that referenced this pull request Jan 6, 2026
- Updated P12 plan with completed items #3 and #4
- Updated WORK.md with Phase 1-3 completion status
nikolausWest added a commit that referenced this pull request Jan 13, 2026
…ests

## Issue #3: Extract magic string to constant
- Created _EMPTY_FILTER_PATH constant for "/__rerun_internal__/non_existent"
- Replaced 4 occurrences of the magic string with the constant
- Improves maintainability and clarity

## Issue #4: Add comprehensive empty filter tests
Added 4 new tests for edge cases:
- test_filter_archetypes_multiple_nonexistent: Verify multiple nonexistent archetypes return empty view
- test_filter_archetypes_empty_view_can_be_read: Verify empty views can be read without crashes
- test_filter_component_types_multiple_nonexistent: Verify multiple nonexistent component types return empty view
- test_filter_component_types_empty_view_can_be_read: Verify empty component type views can be read

These tests ensure robust handling of empty results and verify that the
constant behavior (returning empty view) works correctly.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
nikolausWest added a commit that referenced this pull request Jan 15, 2026
…ests

## Issue #3: Extract magic string to constant
- Created _EMPTY_FILTER_PATH constant for "/__rerun_internal__/non_existent"
- Replaced 4 occurrences of the magic string with the constant
- Improves maintainability and clarity

## Issue #4: Add comprehensive empty filter tests
Added 4 new tests for edge cases:
- test_filter_archetypes_multiple_nonexistent: Verify multiple nonexistent archetypes return empty view
- test_filter_archetypes_empty_view_can_be_read: Verify empty views can be read without crashes
- test_filter_component_types_multiple_nonexistent: Verify multiple nonexistent component types return empty view
- test_filter_component_types_empty_view_can_be_read: Verify empty component type views can be read

These tests ensure robust handling of empty results and verify that the
constant behavior (returning empty view) works correctly.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant