Merged
Conversation
Member
|
waiting for ci to finish then trying on my android phone just to be sure |
Wumpf
approved these changes
Jun 13, 2023
Member
Wumpf
left a comment
There was a problem hiding this comment.
Works on my android firefox, android chrome has issues but they are unrelated to this
emilk
added a commit
that referenced
this pull request
Jun 15, 2023
It contains this important fix for Rust 1.70: wasm-bindgen/wasm-bindgen#3463 I tested the web viewer, and it works. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2406 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/eebb149/docs Examples preview: https://rerun.io/preview/eebb149/examples <!-- pr-link-docs:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It contains this important fix for Rust 1.70: wasm-bindgen/wasm-bindgen#3463
I tested the web viewer, and it works.
Checklist
PR Build Summary: https://build.rerun.io/pr/2406
Docs preview: https://rerun.io/preview/eebb149/docs
Examples preview: https://rerun.io/preview/eebb149/examples