SDK batching/revamp 3: sunset PythonSession#1985
Merged
Conversation
f15a4eb to
f0e6ccb
Compare
This was referenced Apr 27, 2023
ac1fac2 to
14130c5
Compare
f0e6ccb to
0f9c232
Compare
0f9c232 to
b872b63
Compare
jleibs
reviewed
Apr 30, 2023
teh-cmc
commented
May 4, 2023
jleibs
approved these changes
May 4, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
That seems straight forward. Nice improvement.
…guages and all weird situations
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
initcalls shouldnt do anything crazyDataTableBatcher#1980SessionwithRecordingContext#1983clockexample for Rust #2000PythonSession#1985On top of #1983
Fixes #1619
Future work:
RecordingStreamto python: Update python APIs to make init return a RecordingHandle which manages most state #1903