Skip to content

URDF loader: Use global material if inline material is absent#11869

Merged
Wumpf merged 2 commits into
mainfrom
gijs/urdf-logger-color-support
Nov 12, 2025
Merged

URDF loader: Use global material if inline material is absent#11869
Wumpf merged 2 commits into
mainfrom
gijs/urdf-logger-color-support

Conversation

@oxkitsune

Copy link
Copy Markdown
Member

What

If a visual’s inline material does not specify a color or texture, use the matching global material instead (if any).

@github-actions

github-actions Bot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Web viewer built successfully.

Result Commit Link Manifest
eb6a88b https://rerun.io/viewer/pr/11869 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

Comment thread crates/store/re_data_loader/src/loader_urdf.rs Outdated
Co-authored-by: Michael Grupp <michael@rerun.io>

@MichaelGrupp MichaelGrupp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Wumpf Wumpf added the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Nov 12, 2025
@Wumpf Wumpf merged commit ff4dd86 into main Nov 12, 2025
43 checks passed
@Wumpf Wumpf deleted the gijs/urdf-logger-color-support branch November 12, 2025 12:15
IsseW pushed a commit that referenced this pull request Nov 12, 2025
@IsseW IsseW removed the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants