Skip to content

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 14, 2025

This is a follow up to #11525. It fixes the remaining half of #11516.

We don't want to merge it as is yet. Let's see if we can get the fix merged upstream first, so we don't have to depend on yet another fork:



Checks:

  • rerun with --nb_scans 3000 now works
  • rerun rrd stats with --nb_scans 3000 now works

@teh-cmc teh-cmc added 🪳 bug Something isn't working do-not-merge Do not merge this PR dependencies concerning crates, pip packages etc 🪵 Log & send APIs Affects the user-facing API for all languages exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/11533 | +nightly +main |

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the cmc/lz4_flex_upstream_fixes branch from 4e98906 to da45a54 Compare October 14, 2025 13:25
@teh-cmc teh-cmc changed the title use patched lz4 crate Use patched lz4 crate Oct 14, 2025
@teh-cmc teh-cmc linked an issue Oct 14, 2025 that may be closed by this pull request
@rerun-io rerun-io deleted a comment from github-actions bot Oct 14, 2025
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 14, 2025

@rerun-bot full-check

@github-actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/18501698194

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 27, 2025

Patch has been merged upstream, waiting for a release to be published.

@Wumpf
Copy link
Member

Wumpf commented Nov 4, 2025

converting to draft so this doesn't show up on review queue

@Wumpf Wumpf marked this pull request as draft November 4, 2025 10:12
@teh-cmc teh-cmc force-pushed the cmc/lz4_flex_upstream_fixes branch from 502d4ff to ef46e6c Compare November 12, 2025 09:01
@teh-cmc teh-cmc force-pushed the cmc/lz4_flex_upstream_fixes branch from ef46e6c to bfec5f3 Compare November 12, 2025 09:03
@teh-cmc teh-cmc changed the title Use patched lz4 crate LZ4 0.12 (fix decoding of unsually large chunks) Nov 12, 2025
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Nov 12, 2025
@teh-cmc teh-cmc marked this pull request as ready for review November 12, 2025 09:07
@teh-cmc teh-cmc merged commit 8fd62ef into main Nov 12, 2025
34 checks passed
@teh-cmc teh-cmc deleted the cmc/lz4_flex_upstream_fixes branch November 12, 2025 09:14
@Wumpf Wumpf added the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Nov 12, 2025
IsseW pushed a commit that referenced this pull request Nov 12, 2025
This is a follow up to #11525. It
fixes the remaining half of
#11516.

We don't want to merge it as is yet. Let's see if we can get the fix
merged upstream first, so we don't have to depend on yet another fork:
* PSeitz/lz4_flex#192

---

* Fixes #11516

---

Checks:
* [x] `rerun` with `--nb_scans 3000` now works
* [x] `rerun rrd stats` with `--nb_scans 3000` now works
@IsseW IsseW removed the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RRD decoder panics on allocation: capacity overflow

4 participants